Created Lichen for ScienceRun1. Updated AmBe FV. Created NG FV #58
Conversation
lax/lichens/sciencerun1.py
Outdated
| (source_position[2] - df['z']) ** 2) ** 0.5 | ||
| return df | ||
|
|
||
| class AmBeFiducial(StringLichen): |
There was a problem hiding this comment.
Repeated definition? (also shows up in codacy check below, please go through this)
|
Removed the doubled definition |
|
Should the Also, please click "Details" next to failed "codacy/pr" check, and fix as many as you can. |
|
Will do. We can update sciencerun0. I see no reason why that would not be a good idea. @andrewgrahambrown any objections |
pdeperio
dismissed
their stale review
Should update sciencerun0 AmBe FV cut as well
This should fix the style errors found here: https://www.codacy.com/app/weiyuehuan/lax/pullRequest?prid=694964
Fix for remaining 3 errors here: https://www.codacy.com/app/tunnell/lax/pullRequest?prid=694950 . Hope this will fix all
lax/lichens/sciencerun1.py
Outdated
|
|
||
| S2Tails = sciencerun0.S2Tails | ||
|
|
||
| FiducialCylinder1T = sciencerun0.S2Tails |
lax/lichens/sciencerun1.py
Outdated
| S1PatternLikelihood(), | ||
| S2Width(), | ||
| S1MaxPMT(), | ||
| SingleElectronS2s() |
There was a problem hiding this comment.
@feigaodm: is this still needed after XENON1T/pax#576?
If not, I guess we should remove from SR0 lichen too once SR0 gets reprocessed?
|
@jpienaar13 please also commit the AmBe FV SR0 fix to this branch. |
Corrected wrong dependency of FiducialCylinder1T cut
|
Do we want to keep the old incorrect volume, or just update SR0 AmBe fiducial to the correct one? |
|
Just update with new version number. |
|
Done |
|
@jpienaar13 I think you accidentally introduced style error |
|
@tunnell That comment is a little cryptic. |
|
@jpienaar13 do you see how it says that a check had failed? Also, @pdeperio needs to say if you satisfied the changes requested in the review. @jpienaar13 But yeah, you see where it says "All checks have failed", then "codacy/pr", on the right is "details" that takes you here: https://www.codacy.com/app/weiyuehuan/lax/pullRequest?prid=694964 It's just trailing white space on line 94 so tiny to fix. |
|
@tunnell Eh, I thought I fixed that one yesterday. |
|
You can just edit the file on the github website. |
redundant since we added it in pax (XENON1T/pax#576)
|
@tunnell seems like the codacy report doesn't show all the issues at once (they appear one at a time as you fix online). so i just did |
|
@jpienaar13: @tunnell noticed that maybe this corrected AmBe FV should have gone into |
|
That is correct yes. |
|
ah he opened an issue here #95 |
Corrected definition of AmBe FV in sciencerun0 to reflect the correct source position, as mentioned by Dominic: https://xecluster.lngs.infn.it/dokuwiki/doku.php?id=xenon:xenon1t:analysis:dominick:sr1_ambe_check
Created NG FV. (Not sure if needed, but at least it's there if we do):
https://xecluster.lngs.infn.it/dokuwiki/doku.php?id=xenon:xenon1t:analysis:dominick:ng_early_look