Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove S2 tail cut from calibration modes #88

Merged
merged 3 commits into from
Dec 1, 2017
Merged

Remove S2 tail cut from calibration modes #88

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7efd1e3
Remove S2 tail cut from calibration modes
coderdj Oct 26, 2017
4e182a1
Update sciencerun1.py
coderdj Oct 26, 2017
4c43e85
Remove S2 Tail cut from calibration modes
coderdj Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lax/lichens/sciencerun1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ class LowEnergyRn220(AllEnergy):

def __init__(self):
AllEnergy.__init__(self)

# S2Tails not used in calibration modes
self.lichen_list.pop(8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just delete the cut from the AllEnergy list above (like in #86)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could. Technically it may also belong in "AllEnergy" since it should work the same at all energy scales.

Copy link
Contributor

@pdeperio pdeperio Oct 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see sorry, missed that this was in LowEnergyRn220.

Maybe should move below:

self.lichen_list[4] = S2SingleScatterSimple()

in case future people pop more and affect the indexing of the cuts below.


# Replaces Interaction exists
self.lichen_list[1] = S1LowEnergyRange()

Expand All @@ -78,6 +82,7 @@ def __init__(self):

self.lichen_list += [
PreS2Junk(),
S2Tails()
]


Expand Down