Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

SE shape: optical propagation + anode focusing #320

Merged
merged 22 commits into from
Mar 28, 2022
Merged

Conversation

KaraMelih
Copy link
Contributor

What is the problem / what does the code in this PR do
Single Electron shape data-simulation matching improvements
Jianyang's note
Melih's note
WFSim needs you:

  • Please add a test for this PR, as a bare minimum, make sure it's covered in coveralls!
  • Can you add a docsting to all your functions?

Pay attention:

  • Due to databases being needed for testing, making a PR from your own fork will typically NOT run the tests. If you then merge master might break

@KaraMelih KaraMelih marked this pull request as ready for review February 16, 2022 13:50
@zhut19
Copy link
Contributor

zhut19 commented Feb 18, 2022

@KaraMelih and @JYangQi00 Thanks for checking and helping match the SE pulse shape. There's an update on the liquid level in the default simulation setting. Can you check how much change this can bring and also update the other parameters to match the data given the update? TYSM

@JYangQi00
Copy link
Contributor

JYangQi00 commented Feb 21, 2022 via email

@JYangQi00 JYangQi00 changed the title Jianyang wfsim tests Single Electron Shape Matching: Optical propagation + extraction below the anode Mar 25, 2022
@ramirezdiego ramirezdiego changed the title Single Electron Shape Matching: Optical propagation + extraction below the anode SE shape: optical propagation + anode focusing Mar 25, 2022
@zhut19
Copy link
Contributor

zhut19 commented Mar 26, 2022

@KaraMelih I also uploaded the optical map in a format that can be directly used by straxen in https://github.com/XENONnT/private_nt_aux_files/pull/167. Can you help double-check it's consistent with your result? Thanks! Also, that pr has to be merged before the tests here pass since the test on that part fetches the file through our MongoDB, which only updates with the master branch.

@terliuk terliuk merged commit b4dc86f into master Mar 28, 2022
@terliuk terliuk deleted the jianyang_wfsim_tests branch March 28, 2022 18:51
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 81.189% when pulling 912eb0e on jianyang_wfsim_tests into b45a100 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants