Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tarball alea for later user installation #215

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Tarball alea for later user installation #215

merged 6 commits into from
Sep 19, 2024

Conversation

dachengx
Copy link
Collaborator

@coveralls
Copy link

coveralls commented Sep 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10943275946

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.51%
Totals Coverage Status
Change from base Build 10935467788: 0.0%
Covered Lines: 1681
Relevant Lines: 1878
💛 - Coveralls

@dachengx dachengx marked this pull request as ready for review September 19, 2024 06:14
FaroutYLq
FaroutYLq approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@FaroutYLq FaroutYLq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see it is the same elegant logic as the one in outsource. Good job.

@dachengx dachengx merged commit dfc6377 into main Sep 19, 2024
7 checks passed
@dachengx dachengx deleted the tarball_install branch September 19, 2024 14:51
@dachengx dachengx mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FaroutYLq FaroutYLq FaroutYLq approved these changes

@hammannr hammannr Awaiting requested review from hammannr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dachengx @coveralls @FaroutYLq