Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball strax(en) and cutax for later user installation #175

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

dachengx
Copy link
Contributor

Depends on XENONnT/utilix#125.

  1. Outsource.make_tarballs will make tarball of strax, straxen, and cutax if they are in editable user-installed mode.
  2. outsource/workflow/install.sh will install them if a tarball is found.

@dachengx dachengx requested a review from FaroutYLq September 15, 2024 20:34
Copy link
Collaborator

@FaroutYLq FaroutYLq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the restructuring. I read it thoroughly and didn't spot any problem. If you have already tested and a workflow has been finished successfully, please just merge it (otherwise please let me know). I will make an issue for people to practice, regarding the hardcoded to-install packages. Oh wait there is already an issue.

outsource/outsource.py Show resolved Hide resolved
outsource/outsource.py Show resolved Hide resolved
outsource/outsource.py Show resolved Hide resolved
outsource/outsource.py Outdated Show resolved Hide resolved
@dachengx dachengx merged commit fabf960 into master Sep 16, 2024
1 check passed
@dachengx dachengx deleted the tarball_install branch September 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants