-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file hash to blueice hash #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked that it works but quickly want to add a unittest and do a few more checks tomorrow. |
But if you already have any code-related suggestions @dachengx please let me know 😊 |
Ohhh ok nvm -- it kills some unittests, I'll fix it tomorrow.. |
Pull Request Test Coverage Report for Build 11192305157Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 11192305157Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 11306766215Details
💛 - Coveralls |
For the pre-commit problem, you can either merge while ignoring it or implement this: PyCQA/docformatter#287 (comment) |
dachengx
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, if you made changes to a template that was already cached by blueice, blueice would use the cached version instead of the new one. This PR solves this issue by computing the hash of each source's template file and adding it to the blueice source config.