Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file hash to blueice hash #225

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Add file hash to blueice hash #225

merged 5 commits into from
Oct 13, 2024

Conversation

hammannr
Copy link
Collaborator

@hammannr hammannr commented Oct 4, 2024

So far, if you made changes to a template that was already cached by blueice, blueice would use the cached version instead of the new one. This PR solves this issue by computing the hash of each source's template file and adding it to the blueice source config.

@hammannr hammannr added the bugfix label Oct 4, 2024
@hammannr hammannr requested a review from dachengx October 4, 2024 18:14
@hammannr
Copy link
Collaborator Author

hammannr commented Oct 4, 2024

I checked that it works but quickly want to add a unittest and do a few more checks tomorrow.

@hammannr
Copy link
Collaborator Author

hammannr commented Oct 4, 2024

But if you already have any code-related suggestions @dachengx please let me know 😊

@hammannr
Copy link
Collaborator Author

hammannr commented Oct 4, 2024

Ohhh ok nvm -- it kills some unittests, I'll fix it tomorrow..

@hammannr hammannr marked this pull request as ready for review October 5, 2024 10:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11192305157

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 89.684%

Files with Coverage Reduction New Missed Lines %
alea/parameters.py 1 90.91%
Totals Coverage Status
Change from base Build 11162947732: 0.1%
Covered Lines: 1704
Relevant Lines: 1900

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11192305157

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 89.684%

Files with Coverage Reduction New Missed Lines %
alea/parameters.py 1 90.91%
Totals Coverage Status
Change from base Build 11162947732: 0.1%
Covered Lines: 1704
Relevant Lines: 1900

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 5, 2024

Pull Request Test Coverage Report for Build 11306766215

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.684%

Totals Coverage Status
Change from base Build 11293414625: 0.2%
Covered Lines: 1704
Relevant Lines: 1900

💛 - Coveralls

@dachengx
Copy link
Collaborator

dachengx commented Oct 12, 2024

For the pre-commit problem, you can either merge while ignoring it or implement this: PyCQA/docformatter#287 (comment)

@hammannr hammannr merged commit 87152d2 into main Oct 13, 2024
6 of 7 checks passed
@hammannr hammannr deleted the fix_pdf_cache branch October 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants