Exciton ratio

[HenningSE]

What does the code in this PR do / what does it improve?

This PR will exchange the number of excitons in the S1 timing simulation by the ratio of excitons to photons. It aims at solving #239.

Please include the following if applicable:

• Update the docstring(s)
• Bump plugin version(s)
• Update the documentation
• Tests to check the (new) code is working as desired.
• Does it solve one of the GitHub open issues?

[coveralls]

Pull Request Test Coverage Report for Build 10053986419

Details

• 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 80.025%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
fuse/plugins/micro_physics/yields.py	2	3	66.67%

Totals
Change from base Build 10053983233:	-0.02%
Covered Lines:	2532
Relevant Lines:	3164

---

💛 - Coveralls

[ramirezdiego]

Thanks, Henning! To recap, we should agree on one of these two options:

1. We calculate this ratio in the yields plugin, but then need to warn the user to set it in the instructions that bypass this step (and modify the csv input instructions accordingly).
2. We make the calculation of this ratio only within the S1 propagation class.

I prefer the second, to avoid burdens to the users, but either is fine.

[HenningSE]

Hi @ramirezdiego, thanks for your feedback. I opened a PR with option 2 here #251. We can then decide which one is better and merge one of the two PRs.

[ramirezdiego]

Thanks! I prefer the second, hence closing this one.