-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multi scatter Ignore nan in the sum of peaks. #1162
Conversation
@HenningSE I guess we are good to merge if we make some decisions on the FDC correction. : ) |
Or I guess we can also implement the FDC-corrected z later. |
@HenningSE Do you think this PR is in good shape to merge? Or what are the ongoing or pending development? |
Hi @dachengx, sorry I think I missed your question a few days ago. As far as I can tell, the FDC correction was basically copy and paste from the existing straxen code. From my perspective the PR can be merged! Thanks for you help! |
Hey @HenningSE . The I will merge it after the test passes. |
Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
It ignores nan in the sum.
Can you briefly describe how it works?
It ignores nan in the sum.
Can you give a minimal working example (or illustrate with a figure)?
Same as before
considerations._
All italic comments can be removed from this template.