Skip to content

Commit

Permalink
Fix Windows build by removing two unused declarations (#4708)
Browse files Browse the repository at this point in the history
Remove the `verify` and `message` function declarations. The explicit
instantiation requests could not be completed because there were no
implementations for those two member functions. It is helpful that the
Microsoft (MSVC) compiler on Windows appears to be strict when it comes
to template instantiation.

This resolves the warning:

  XChainAttestations.h(450): warning C4661: 'bool
  ripple::XChainAttestationsBase<ripple::XChainClaimAttestation>::verify(void)
  const': no suitable definition provided for explicit template
  instantiation request
  • Loading branch information
seelabs authored Sep 15, 2023
1 parent 5427321 commit 237b406
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/ripple/protocol/XChainAttestations.h
Original file line number Diff line number Diff line change
Expand Up @@ -437,16 +437,6 @@ class XChainAttestationsBase
template <class T>
void
emplace_back(T&& att);

// verify that all the signatures attest to transaction data.
[[nodiscard]] bool
verify() const;

protected:
// Return the message that was expected to be signed by the attesters given
// the data to be proved.
[[nodiscard]] std::vector<std::uint8_t>
message() const;
};

template <class TAttestation>
Expand Down

0 comments on commit 237b406

Please sign in to comment.