Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove two unused functions #4708

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Remove two unused functions #4708

merged 1 commit into from
Sep 15, 2023

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented Sep 14, 2023

No description provided.

ximinez
ximinez approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good, safe change. And it builds.

@intelliot intelliot mentioned this pull request Sep 15, 2023
Merged
1 task
scottschurr
scottschurr approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. Good to get rid of unused/unimplemented interfaces. Everything builds / passes tests / syncs on MacOS.

@scottschurr scottschurr added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Sep 15, 2023
@intelliot intelliot merged commit 237b406 into XRPLF:develop Sep 15, 2023
15 checks passed
@intelliot intelliot mentioned this pull request Sep 18, 2023
Merged
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 22, 2023
@seelabs @ckeshava
Fix Windows build by removing two unused declarations (XRPLF#4708)
659fbed 
Remove the `verify` and `message` function declarations. The explicit
instantiation requests could not be completed because there were no
implementations for those two member functions. It is helpful that the
Microsoft (MSVC) compiler on Windows appears to be strict when it comes
to template instantiation.

This resolves the warning:

  XChainAttestations.h(450): warning C4661: 'bool
  ripple::XChainAttestationsBase<ripple::XChainClaimAttestation>::verify(void)
  const': no suitable definition provided for explicit template
  instantiation request
ckeshava pushed a commit to ckeshava/rippled that referenced this pull request Sep 25, 2023
@seelabs @ckeshava
Fix Windows build by removing two unused declarations (XRPLF#4708)
28a9981 
Remove the `verify` and `message` function declarations. The explicit
instantiation requests could not be completed because there were no
implementations for those two member functions. It is helpful that the
Microsoft (MSVC) compiler on Windows appears to be strict when it comes
to template instantiation.

This resolves the warning:

  XChainAttestations.h(450): warning C4661: 'bool
  ripple::XChainAttestationsBase<ripple::XChainClaimAttestation>::verify(void)
  const': no suitable definition provided for explicit template
  instantiation request
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@seelabs @sophiax851
Fix Windows build by removing two unused declarations (XRPLF#4708)
a52be80 
Remove the `verify` and `message` function declarations. The explicit
instantiation requests could not be completed because there were no
implementations for those two member functions. It is helpful that the
Microsoft (MSVC) compiler on Windows appears to be strict when it comes
to template instantiation.

This resolves the warning:

  XChainAttestations.h(450): warning C4661: 'bool
  ripple::XChainAttestationsBase<ripple::XChainClaimAttestation>::verify(void)
  const': no suitable definition provided for explicit template
  instantiation request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

@scottschurr scottschurr scottschurr approved these changes

Assignees

@scottschurr scottschurr

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seelabs @ximinez @scottschurr @intelliot