Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division by zero and directory removal in shards #3343

Closed
wants to merge 2 commits into from

Conversation

miguelportilla
Copy link
Contributor

No description provided.

@miguelportilla miguelportilla requested review from nbougalis and a user April 8, 2020 19:59
@miguelportilla miguelportilla assigned nbougalis and ghost Apr 8, 2020
@codecov-io
Copy link

codecov-io commented Apr 8, 2020

Codecov Report

Merging #3343 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3343      +/-   ##
===========================================
- Coverage    70.46%   70.45%   -0.02%     
===========================================
  Files          684      684              
  Lines        55001    55006       +5     
===========================================
- Hits         38759    38756       -3     
- Misses       16242    16250       +8     
Impacted Files Coverage Δ
src/ripple/nodestore/impl/DatabaseShardImp.cpp 13.22% <0.00%> (+0.14%) ⬆️
src/ripple/nodestore/impl/Shard.cpp 0.00% <0.00%> (ø)
src/ripple/nodestore/impl/Shard.h 0.00% <0.00%> (ø)
src/ripple/server/impl/BaseHTTPPeer.h 87.57% <0.00%> (-3.56%) ⬇️
src/ripple/basics/DecayingSample.h 86.48% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f422f6...a5d8fef. Read the comment docs.

@nbougalis nbougalis mentioned this pull request Apr 15, 2020
@carlhua carlhua added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 15, 2020
@miguelportilla miguelportilla deleted the shard_fixes branch April 30, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants