Proposed 1.6.0-b2 #3357
Merged
Proposed 1.6.0-b2 #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically strand re-execute log messages have been treated as errors. However in the vast majority of cases these log messages are caused by well understood mechanics in the payment engine. So usually these log messages should be treated as warnings.
* Use official build environment Docker image * Update documentation and Doxygen website URLs
The package 'apt-transport-https' needs to be downloaded and installed in order for the build pipeline to successfully complete builds.
Existing per-thread PRNGs are individually initialized using calls
to std::random_device.
If merged, this commit will use a single PRNG, initialized from
std::random_device on startup, to seed the thread-specific PRNGs.
Acknowledgements:
Thomas Snider, who reported this issue to Ripple on April 8, 2020.
Codecov Report
@@ Coverage Diff @@
## develop #3357 +/- ##
===========================================
- Coverage 70.46% 70.40% -0.07%
===========================================
Files 684 683 -1
Lines 55001 54775 -226
===========================================
- Hits 38759 38564 -195
+ Misses 16242 16211 -31
Continue to review full report at Codecov.
|
|
I don't see any doc impacts from these changes, other than previously-known "unconditionalizing" amendments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR will close #3292, close #3304 (which resolves #3276), close #3305 (which resolves #3277), close #3319, close #3341, close #3343, close #3344, close #3345, close #3347, close #3351, close #3352 and close #3353.