Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRIVIAL] Improve handling of empty buffer in varint parsing (RIPD-1683) #3446

Closed
wants to merge 1 commit into from
Closed

[TRIVIAL] Improve handling of empty buffer in varint parsing (RIPD-1683) #3446

wants to merge 1 commit into from

Conversation

HowardHinnant
Copy link
Contributor

No description provided.

seelabs
seelabs approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@HowardHinnant HowardHinnant added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jun 9, 2020
This was referenced Jun 25, 2020
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seelabs seelabs seelabs approved these changes

Assignees

@seelabs seelabs

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HowardHinnant @seelabs