Proposed 1.6.0-b8 #3461
Closed
Proposed 1.6.0-b8 #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on a version 2 of the XRP Network API has begun. The new API returns: * `notSynced` in place of `noClosed`, `noCurrent`, and `noNetwork`; * `invalidParams` in place of `lgrIdxInvalid`. The new version 2 API cannot be selected yet, as it remains a work in progress. Fixes XRPLF#3269
Slice should, eventually, be replaced by std::string_view<std::uint8_t> so begin adding some helpful functions to align its interface.
* Improve error reporting (more readable exception messages) * Reduce function complexity (split oversized function to smaller pieces) * Reduce code duplication * Reduce buffer copying
* Optimize parsing of compressed message headers * Enforce protocol-defined message size maxima * Update comments
* The amendment ballot counting code contained a minor technical flaw, caused by the use of integer arithmetic and rounding semantics, that could allow amendments to reach majority with slightly less than 80% support. This commit introduces an amendment which, if enabled, will ensure that activation requires at least 80% support. * This commit also introduces a configuration option to adjust the amendment activation hysteresis. This option is useful on test networks, but should not be used on the main network as is a network-wide consensus parameter that should not be changed on a per-server basis; doing so can result in a hard-fork. Fixes XRPLF#3396
* Document delete_batch, back_off_milliseconds, age_threshold_seconds. * Convert those time values to chrono types. * Fix bug that ignored age_threshold_seconds. * Add a "recovery buffer" to the config that gives the node a chance to recover before aborting online delete. * Add begin/end log messages around the SQL queries. * Add a new configuration section: [sqlite] to allow tuning the sqlite database operations. Ignored on full/large history servers. * Update documentation of [node_db] and [sqlite] in the rippled-example.cfg file. Resolves XRPLF#3321
If the 'HardenedValidations' amendment is enabled, this commit will track the version of the software that validators embed in their validations. If a server notices that at least 60% of the validators on its UNL are running a newer version than it is running, it will periodically print an informational message, reminding the operator to check for update.
This commit, if merged, adds support to allow multiple indepedent nodes to produce a binary identical shard for a given range of ledgers. The advantage is that servers can use content-addressable storage, and can more efficiently retrieve shards by downloading from multiple peers at once and then verifying the integrity of a shard by cross-checking its checksum with the checksum other servers report.
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
The amendment was partially complete, included no functional code and, even if activated, it would result in no changes to transaction proessing. Despite this, removing the amendment is the prudent course of action and avoids the possibility of an accidental activation. If additional cryptoconditions are implemented, they will be each assigned a new, unique amendment code.
The tecUNFUNDED code is actively used when attempting to create payment channels; the messages incorrectly list it as deprecated. Meanwhile, the tecUNFUNDED_ADD code actually is an unused legacy code, dating back to when there was a WalletAdd transactor. The terLAST and terFUNDS_SPENT codes are also unused legacy codes. Engine result messages are not part of the binary format and are documented as subject to change without notice, so this should not require an amendment nor a new API version. Align error code table for human readability.
manojsdoshi
force-pushed
the
develop-next
branch
from
d5900e1
to
76096ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR:
closes #3363
closes #3398
closes #3418
closes #3419
closes #3421
closes #3428
closes #3429
closes #3437
closes #3446
closes #3447
closes #3448
closes #3449
closes #3450
closes #3451
closes #3453
closes #3456