crawl_shards comment fix #3450
Closed
crawl_shards comment fix #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
reviewed
Jun 11, 2020
There was a problem hiding this comment.
@mDuo13 you are changing the code and not the comment.
Failing build: https://gitlab.ops.ripple.com/xrpledger/rippled-packages/-/commit/cb4b16383a872c037c4278e51d48307bf425a207
|
It's a multiline comment. But I think the problem is I accidentally opened this PR to the wrong branch (should be to develop) |
carlhua
added
the
Passed
This was referenced Jun 25, 2020
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the public_key parameter name in the comment.
See XRPLF/xrpl-dev-portal#854 for context.