Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ipv6 remote client addresses for secure_gatway. #4030

Closed
wants to merge 1 commit into from
Closed

Handle ipv6 remote client addresses for secure_gatway. #4030

wants to merge 1 commit into from

Conversation

natenichols
Copy link
Contributor

This commit was authored by @mtrippled and has been running on reporting servers.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@scottschurr
Copy link
Collaborator

I suggest we close this pull request. There's an improved and more thoroughly tested equivalent here: #4009. By good fortune that pull request has already passed code review.

scottschurr
scottschurr requested changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we close this pull request. There's an improved and more thoroughly tested equivalent here: #4009. By good fortune that pull request has already passed code review.

@ximinez ximinez self-requested a review December 14, 2021 21:56
@ximinez ximinez self-assigned this Dec 14, 2021
@natenichols
Copy link
Contributor Author

I suggest we close this pull request. There's an improved and more thoroughly tested equivalent here: #4009. By good fortune that pull request has already passed code review.

@thejohnfreeman
Copy link
Collaborator

Is there an echo in here? 👂

This was referenced Dec 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottschurr scottschurr scottschurr requested changes

@ximinez ximinez Awaiting requested review from ximinez

Assignees

@ximinez ximinez

@mtrippled mtrippled

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@natenichols @scottschurr @thejohnfreeman @ximinez @mtrippled