Proposed 1.8.2-rc1 #4040
Merged
Proposed 1.8.2-rc1 #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag, if present, suppresses the output of incoming trustlines in default state. This is primarily motivated by observing that users of Xumm often have many unwanted incoming trustlines in a default state, which are not useful in the vast majority of cases. Being able to suppress those when doing `account_lines` saves bandwidth and resources.
* Just the rep is made atomic to workaround older compilers
seperated -> separated
determing -> determining
* Log load fee values (at debug) received from validations. * Log remote and cluster fee values (at trace) when changed. * Refactor JobQueue::isOverloaded to return sooner if overloaded. * Refactor Transactor::checkFee to only compute fee if ledger is open.
* Sort by fee level (which is the current behavior) then by transaction ID (hash). * Edge case when the account at the end of the queue submits a higher paying transaction to walk backwards and compare against the cheapest transaction from a different account. * Use std::if_any to simplify the JobQueue::isOverloaded loop.
manojsdoshi
force-pushed
the
develop-next
branch
from
483b438
to
6703508
Compare
manojsdoshi
force-pushed
the
develop-next
branch
from
6703508
to
4ec11e6
Compare
sgramkumar
approved these changes
Dec 17, 2021
scottschurr
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged this PR will:
close #4028
close #4029
close #4030
close #4031
close #4032
close #4033
close #4034
close #4035
close #4036
close #4009
close #4017
close #3980
close #3987
close #4024
close #4008
close #4004
close #3994
close #3980
close #3972
close #4022