Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API CHANGELOG for XRPFees changes #4741

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Update API CHANGELOG for XRPFees changes #4741

merged 4 commits into from
Oct 6, 2023

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Oct 3, 2023

High Level Overview of Change

  • Adds a new section for release 1.10.
  • Also marks jss::fee_ref as deprecated in case XRPFees is ever retired.
  • Also fixes a copy-paste error in one of the unit tests related to that fix.

Context of Change

See also:

Type of Change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • [X ] Tests (You added tests for code that already exists, or your new feature included in this PR)
  • [X ] Documentation Updates

@ximinez
Update API CHANGELOG for XRPFees changes
7495c02 
* Adds a new section for release 1.10.
* Also marks `jss::fee_ref` as deprecated in case `XRPFees` is ever
  retired.
* Also fixes a copy-paste error in one of the unit tests related to that
  fix.
@ximinez ximinez requested a review from intelliot October 3, 2023 20:03
intelliot
intelliot approved these changes Oct 3, 2023
View reviewed changes
API-CHANGELOG.md Outdated Show resolved Hide resolved
@ximinez @intelliot
Take @intelliot's suggestion to add link
012a9cc 
Co-authored-by: Elliot Lee <github.public@intelliot.com>
@ximinez
Merge remote-tracking branch 'upstream/develop' into XRPFees_fee_ref
c260112 
* upstream/develop:
  refactor: reunify transaction common fields: (4715)
  fix typo in SECURITY.md (4662)
  docs(API-CHANGELOG): clarify account_info response (4724)
  fix: asan stack-use-after-scope in soci::use with rvalues (4676)
@ximinez
Merge remote-tracking branch 'upstream/develop' into XRPFees_fee_ref
5c82866 
* upstream/develop:
  `fixDisallowIncomingV1`: allow issuers to authorize trust lines (4721)
  refactor: reduce boilerplate in applySteps: (4710)
pwang200
pwang200 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@intelliot intelliot mentioned this pull request Oct 6, 2023
Merged
@intelliot intelliot added the Documentation README changes, code comments, etc. label Oct 6, 2023
@intelliot intelliot added this to the 2.0 milestone Oct 6, 2023
@intelliot
Copy link
Collaborator

note: awaiting Passed label or confirmation from ximinez that this is ready to merge

@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Oct 6, 2023
@intelliot intelliot merged commit 053b69c into XRPLF:develop Oct 6, 2023
15 checks passed
@ximinez ximinez deleted the XRPFees_fee_ref branch October 6, 2023 20:05
@intelliot
Copy link
Collaborator

sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@ximinez @sophiax851
docs(API-CHANGELOG): add XRPFees change (XRPLF#4741)
a2691f7 
* Add a new API Changelog section for release 1.10.
* Mark `jss::fee_ref` as deprecated.
* Fix a copy-paste error in one of the unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelliot intelliot intelliot approved these changes

@pwang200 pwang200 pwang200 approved these changes

@seelabs seelabs Awaiting requested review from seelabs

Assignees
No one assigned
Labels
Documentation README changes, code comments, etc. Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
Core Ledger
Archived in project
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ximinez @intelliot @pwang200