Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API CHANGELOG for XRPFees changes #4741

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Update API CHANGELOG for XRPFees changes #4741

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7495c02
Update API CHANGELOG for `XRPFees` changes
ximinez Oct 3, 2023
012a9cc
Take @intelliot's suggestion to add link
ximinez Oct 3, 2023
c260112
Merge remote-tracking branch 'upstream/develop' into XRPFees_fee_ref
ximinez Oct 5, 2023
5c82866
Merge remote-tracking branch 'upstream/develop' into XRPFees_fee_ref
ximinez Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions API-CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,17 @@ Additions are intended to be non-breaking (because they are purely additive).
- Added `NFTokenPages` to the `account_objects` RPC. (https://github.com/XRPLF/rippled/pull/4352)
- Fixed: `marker` returned from the `account_lines` command would not work on subsequent commands. (https://github.com/XRPLF/rippled/pull/4361)

## XRP Ledger version 1.10.0

[Version 1.10.0](https://github.com/XRPLF/rippled/releases/tag/1.10.0)
was released on Mar 14, 2023.

### Breaking changes in 1.10

- If the `XRPFees` feature is enabled, the `fee_ref` field will be
removed from the Ledger subscription stream, because it will no longer
ximinez marked this conversation as resolved.
Show resolved Hide resolved
have any meaning.

# In development

Changes below this point are in development.
Expand Down
2 changes: 1 addition & 1 deletion src/ripple/protocol/jss.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ JSS(fee_base); // out: NetworkOPs
JSS(fee_div_max); // in: TransactionSign
JSS(fee_level); // out: AccountInfo
JSS(fee_mult_max); // in: TransactionSign
JSS(fee_ref); // out: NetworkOPs
JSS(fee_ref); // out: NetworkOPs, DEPRECATED
JSS(fetch_pack); // out: NetworkOPs
JSS(first); // out: rpc/Version
JSS(firstSequence); // out: NodeToShardStatus
Expand Down
6 changes: 3 additions & 3 deletions src/test/app/TxQ_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4843,13 +4843,13 @@ class TxQ1_test : public beast::unit_test::suite
drops[jss::base_fee] == "0");
BEAST_EXPECT(
drops.isMember(jss::median_fee) &&
drops[jss::base_fee] == "0");
drops[jss::median_fee] == "0");
BEAST_EXPECT(
drops.isMember(jss::minimum_fee) &&
drops[jss::base_fee] == "0");
drops[jss::minimum_fee] == "0");
BEAST_EXPECT(
drops.isMember(jss::open_ledger_fee) &&
drops[jss::base_fee] == "0");
drops[jss::open_ledger_fee] == "0");
}
}

Expand Down