Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve code coverage reporting + codecov #4849

Merged
merged 23 commits into from
Jan 22, 2024
Merged

test: improve code coverage reporting + codecov #4849

merged 23 commits into from
Jan 22, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Dec 8, 2023 •
edited
Loading

High Level Overview of Change

Currently coverage reports take a very long time to generate. This can be improved by using multiple cores, with tools which know how to use them. Also add codecov integration.

Newly added CodeCoverage.cmake has been copied from cmake-modules, then updated.

NOTE This PR should only be merged by someone with administrative access to the repo, since it makes use of secrets in .github workflow. A commit (merge) made by someone without access to repo secrets would result in this change not having this access either, which will lead to spurious failures of codecov integration

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@Bronek Bronek force-pushed the feature/coverage_report branch 17 times, most recently from fccaca4 to a483095 Compare December 12, 2023 15:59
@Bronek Bronek mentioned this pull request Dec 12, 2023
Merged
@Bronek Bronek force-pushed the feature/coverage_report branch 12 times, most recently from 9be8359 to 44ca5f9 Compare December 14, 2023 19:21
@Bronek
Copy link
Collaborator Author

Bronek commented Jan 22, 2024

this is good to merge (pls. squash when merging)

@intelliot intelliot merged commit fad9d63 into XRPLF:develop Jan 22, 2024
17 checks passed
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
820dc4b 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
53095d0 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
a23e9c5 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
588f84d 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
a29f438 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
7a422f6 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
bde3aa6 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
de4e34f 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
ac6b2fe 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
f3ea021 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
d34db60 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
b01bb66 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
e1ad1a4 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
7670bb6 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 22, 2024
@Bronek @ximinez
test: improve code coverage reporting (XRPLF#4849)
e3eb189 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
@intelliot intelliot changed the title Improve coverage reporting test: improve code coverage reporting + codecov Jan 23, 2024
@intelliot intelliot mentioned this pull request Jan 23, 2024
Merged
9 tasks
intelliot pushed a commit that referenced this pull request Jan 25, 2024
@Bronek
chore: retry codecov upload (#4896)
901152b 
Update to #4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 26, 2024
@Bronek @ximinez
chore: retry codecov upload (XRPLF#4896)
9e6fb60 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 26, 2024
@Bronek @ximinez
chore: retry codecov upload (XRPLF#4896)
d1ba752 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 26, 2024
@Bronek @ximinez
chore: retry codecov upload (XRPLF#4896)
34a789c 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 26, 2024
@Bronek @legleux
chore: retry codecov upload (XRPLF#4896)
3ccf06d 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 26, 2024
@Bronek @legleux
chore: retry codecov upload (XRPLF#4896)
6c800a8 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 27, 2024
@Bronek @legleux
chore: retry codecov upload (XRPLF#4896)
f1067b0 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 27, 2024
@Bronek @legleux
chore: retry codecov upload (XRPLF#4896)
8efc012 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@Bronek @sophiax851
test: improve code coverage reporting (XRPLF#4849)
086426e 
* Speed up the generation of coverage reports by using multiple cores.

* Add codecov step to coverage workflow.
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
@Bronek @sophiax851
chore: retry codecov upload (XRPLF#4896)
b8bb1de 
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

@ximinez ximinez ximinez approved these changes

Assignees

@Bronek Bronek

Labels
Perf impact not expected Change is not expected to improve nor harm performance.
Projects
Core Ledger
Archived in project
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Bronek @codecov-commenter @intelliot @thejohnfreeman @ximinez