Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Retry codecov uploads #4896

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Jan 23, 2024

High Level Overview of Change

As a workaround for spurious codecov upload errors, wrap codecov/codecov-action@v3 into a wandalen/wretry.action@v1.3.0 action

Context of Change

Spurious codecov upload errors are documented and expected in public repos which rely on PRs via forks, like we do. The underlying cause is API rate-limiting on GitHub due to the lack of access to CODECOV_TOKEN secret from the PR branches on forks. Although the suggested fix is to make the CODECOV_TOKEN effectively public, this comes with security implications which we yet need to consider. Retrying uploads is a decent workaround, which we can apply easily.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@intelliot
Copy link
Collaborator

@Bronek Bronek force-pushed the feature/retry_codecov_upload branch from c20c1a9 to c100167 Compare January 24, 2024 13:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9a5bca) 61.48% compared to head (c20c1a9) 61.48%.

❗ Current head c20c1a9 differs from pull request most recent head c100167. Consider uploading reports for the commit c100167 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4896      +/-   ##
===========================================
- Coverage    61.48%   61.48%   -0.01%     
===========================================
  Files          797      797              
  Lines        70121    70121              
  Branches     36238    36238              
===========================================
- Hits         43116    43113       -3     
- Misses       19762    19763       +1     
- Partials      7243     7245       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bronek
Copy link
Collaborator Author

Bronek commented Jan 24, 2024

this is ready to merge

@intelliot
Copy link
Collaborator

  • ok to merge because it only touches github workflow; no source code change

@intelliot intelliot merged commit 901152b into XRPLF:develop Jan 25, 2024
17 checks passed
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
ximinez pushed a commit to ximinez/rippled that referenced this pull request Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 26, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 27, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
legleux pushed a commit to legleux/rippled that referenced this pull request Jan 27, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Update to XRPLF#4849, using a workaround for spurious codecov upload errors.

Spurious codecov upload errors are expected in public repos which rely
on PRs via forks. Retrying uploads is a decent and easy workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants