This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
near pointer interactions using collision #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
added
Enhancement
2 tasks
StephenHodgson
commented
May 3, 2020
XRTK-Core/Packages/com.xrtk.core/Runtime/Interfaces/InputSystem/IMixedRealityPointer.cs
Outdated
Show resolved
Hide resolved
StephenHodgson
commented
May 3, 2020
...ore/Packages/com.xrtk.core/Runtime/Definitions/InputSystem/MixedRealityInputSystemProfile.cs
Outdated
Show resolved
Hide resolved
…ision # Conflicts: # Submodules/SDK
…ision # Conflicts: # Submodules/SDK
…ision # Conflicts: # Submodules/SDK
* Update ColliderExtensions.cs * Update CollisionExtensions.cs
…ision # Conflicts: # Submodules/SDK
…ision # Conflicts: # Submodules/SDK
…ision # Conflicts: # Submodules/Oculus # Submodules/SDK
|
@FejZa what are we missing for this again? |
|
Well depends on what your intention with this branch is overall. But from my POV this branch is complete. The collision detection works and the events are firing. Everything else I do is hands related I guess. |
|
Agreed, if we need anything else we'll just open another PR or put it in the other one you're working on |
StephenHodgson
added
Ready for review
FejZa
approved these changes
May 14, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* near pointer interactions using collision * revert * Removed unused serialization * updated sdk * Feature/pni change requests (#577) * Update ColliderExtensions.cs * Update CollisionExtensions.cs * updated submodules * updated sdk * updated sdk Co-authored-by: Dino Fejzagic <dino.f@live.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Adds near interaction pointer events using a collider referenced by the pointer.
Target of the change:
Is this enhancement for:
Breaking Changes:
MixedRealityInputSystemProfile.PointingRaycastLayerMasks->MixedRealityInputSystemProfile.PointerRaycastLayerMasksIMixedRealityFocusProvider.FocusLayerMasks->IMixedRealityFocusProvider.GlobalPointerRaycastLayerMasksIMixedRealityPointer.PrioritizedLayerMasksOverride->IMixedRealityPointer.PointerRaycastLayerMasksOverrideIMixedRealityPointer.NearInteractionColliderCollisionExtensions.IsValidCollision(this Collision collision, LayerMask[] prioritizedLayerMasks)Submodule Changes