Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Updated windows hand controller data provider #54

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Mar 29, 2020

Continued from XRTK/com.xrtk.core#476

Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as Oculus, fine with updates but we shouldn't be using a separate data provider for hands

Copy link
Contributor

@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I'll have to verify all of these changes whether things still work as expected.

@FejZa FejZa merged commit 0515cd3 into feature/hand-tracking Mar 30, 2020
@FejZa FejZa deleted the change-requests/hand-tracking branch March 30, 2020 12:05
StephenHodgson added a commit that referenced this pull request Apr 7, 2020
* Add WMR hand controller data provider

* Fix base class

* Implement hand data provider interface

* Remove obsolete WMR platform hand controller data provider

* Resolve merge

* Create controller stub

* Remove need for hand controller data provider profile

* Revert WMR speciifc hand controller

* Create WMR profile for data provider

* Add WMR utilities for hand data conversion

* Fix platform flag for WMR inspector

* Implement WMR hand controller data provider

* Minor refactor

* Fix hand mesh observer request

* Create controller and mapping profile + inspector

* Fix mapping naming

* Add required RefreshActiveControllers override to build

* Removed base hand data provider

* Remove reference to non existin base

* Implement handjointkind extension

* Extend wmr controller interface

* Merge hand and existing controller dp and profile

* Fix wmr controller dp name

* Starting API upgrades

* Revert some changes

* Bring back WMR hand dp profile + inspector

* Add WMR hc dp

* Reimplement wmr hdp

* Implement controller maangement

* Convert to extensions

* Fix source deteced raised twice

* Fix WindowsMixedRealityControllerDataProvider name

* Fix remove all controllers

* Remove WMR hand controller

* Update to MixedRealityHandController agnostic type

* Request only speciif pointers

* Remove redundant if clause

* Move conversion to converter class similar to Oculus

* Fix controller cleanup

* Fix documentation copy paste error

* Add missing method documentation

* Introduce shared hand profile configuraiton

* Introduce base hand controller data provide to consume shared profile

* Introduce HandMeshingEnabled profile setting

* Introduce "Hand Tracking System Profile"

* Updated windows hand controller data provider (#54)

* Updated windows hand controller data provider

* updated base controller data provider profile namespace

* Added WindowsMixedRealityHandControllerDataProviderProfile

* Fusion WMR controller dp profiles

* Housekeeping

* bumped minor version

* Restore wmr profile and inspector

* Restore wmr hand profile and inspector

* Restore wmr hand data provider

* Shorten create asset menu path

* Remove hand ray type setting

* Change requests/hand tracking (#59)

* updated references

* sorted references

* use BaseHandDataProviderProfile

* use BaseHandDataProvider

* Fix compiler issues

* Remove .NET scripting backend support

* Update since BaseHandControllerDataProvider now properly implements the hand interface

* updated extensions

* a bit more organization

* less compiler symbols

* fixed hand data provider inspector

* added IMixedRealityControllerDataProvider constructor param (#61)

* added IMixedRealityControllerDataProvider constructor param

* a bit more cleanup and ensured controllers we being added to the data provider active controller registry

* missed a file

* Fixed memory issue

* misc formatting

Co-authored-by: Dino Fejzagic <dino.f@live.de>
Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* Add WMR hand controller data provider

* Fix base class

* Implement hand data provider interface

* Remove obsolete WMR platform hand controller data provider

* Resolve merge

* Create controller stub

* Remove need for hand controller data provider profile

* Revert WMR speciifc hand controller

* Create WMR profile for data provider

* Add WMR utilities for hand data conversion

* Fix platform flag for WMR inspector

* Implement WMR hand controller data provider

* Minor refactor

* Fix hand mesh observer request

* Create controller and mapping profile + inspector

* Fix mapping naming

* Add required RefreshActiveControllers override to build

* Removed base hand data provider

* Remove reference to non existin base

* Implement handjointkind extension

* Extend wmr controller interface

* Merge hand and existing controller dp and profile

* Fix wmr controller dp name

* Starting API upgrades

* Revert some changes

* Bring back WMR hand dp profile + inspector

* Add WMR hc dp

* Reimplement wmr hdp

* Implement controller maangement

* Convert to extensions

* Fix source deteced raised twice

* Fix WindowsMixedRealityControllerDataProvider name

* Fix remove all controllers

* Remove WMR hand controller

* Update to MixedRealityHandController agnostic type

* Request only speciif pointers

* Remove redundant if clause

* Move conversion to converter class similar to Oculus

* Fix controller cleanup

* Fix documentation copy paste error

* Add missing method documentation

* Introduce shared hand profile configuraiton

* Introduce base hand controller data provide to consume shared profile

* Introduce HandMeshingEnabled profile setting

* Introduce "Hand Tracking System Profile"

* Updated windows hand controller data provider (#54)

* Updated windows hand controller data provider

* updated base controller data provider profile namespace

* Added WindowsMixedRealityHandControllerDataProviderProfile

* Fusion WMR controller dp profiles

* Housekeeping

* bumped minor version

* Restore wmr profile and inspector

* Restore wmr hand profile and inspector

* Restore wmr hand data provider

* Shorten create asset menu path

* Remove hand ray type setting

* Change requests/hand tracking (#59)

* updated references

* sorted references

* use BaseHandDataProviderProfile

* use BaseHandDataProvider

* Fix compiler issues

* Remove .NET scripting backend support

* Update since BaseHandControllerDataProvider now properly implements the hand interface

* updated extensions

* a bit more organization

* less compiler symbols

* fixed hand data provider inspector

* added IMixedRealityControllerDataProvider constructor param (#61)

* added IMixedRealityControllerDataProvider constructor param

* a bit more cleanup and ensured controllers we being added to the data provider active controller registry

* missed a file

* Fixed memory issue

* misc formatting

Co-authored-by: Dino Fejzagic <dino.f@live.de>
Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants