-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Remove more legacy fields #3817
Conversation
已将 Fallback-Fallbacks 错误提示替换并且允许其一直显示到明年之前(v25 移除) |
@APT-ZERO 没绷住 |
after re-reading APT-ZERO's edited message, I think there's a better argument to be had here. I wish that was his initial message. I don't feel strongly about any of these features. I am not a huge fan of userLevel as a concept in general (if you want to configure something per-inbound/outbound, it just seems to get in the way), but I guess it can be used. |
@APT-ZERO Thanks for reaching out about the feature removal problem.
Somehow it does decrease the file size a bit. But the main reason of removal is that this feature miserably haven't occurred into the documents and only appear in the release note. It is not a day one feature, but it was added at a messy time, so not many people know that, and I only found (re-discovered) this feature when I peeked at the code. The removal is only a client-side feature, while when use as a SOCKS server the core still support SOCKS 4/4a. If there are needs of using Xray-core as a Socks 4/4a client, I may revert this part of the modification before being merged.
Better ask maintainers.
Policy does not apply on transports (WS, HTTP/2, gRPC, KCP, etc.), they just apply on proxy protocols, like SOCKS, Shadowsocks, VMESS, VLESS, and even Dokodemo-door and Freedom outbound. Transports may obey the the proxy protocol they're carrying, or having their own policy (KCP and SplitHTTP/h3). For timeout and keepAlive, you can have a look on the |
|
根据 #3821#issuecomment-2354506296, 其更改已经合并至此。 后面还有一个 router 的旧遗留代码清理,但是它的代码调用和相关 tests 比较杂,清理起来比较费时,这个是单开合并还是让这个 pr 等几天然后一起合并? @RPRX @yuhan6665 P.S.:如果有需要标记弃用计划移除的内容也可以现在提出,可以顺手将弃用提示打上 |
I have some concern with the pace of our deletions. But this pr looks ok to me. I will merge later if no objections |
If someone really needs the SOCKS 4/4a as client I can revert that part, and of course I would like to patch the document. But for the unfortunate single timeout config, their coexistence with policy is still embarrassing and would make things messy, like which should be overridden, etc. And for VMess, VLESS, Shadowsocks and Trojan we don't even have single timeout config in the day-one code base and even in the original V2Ray, we just have the policy. A migration would be better, and then we can make the policy config better in the future. Out time and effort are not unlimited, focus on our goal. My focus in mainly on cleaning up the legacy codes, complete the migration process that was halted, and migrate the tests that was mixed with old codes (there are a lot of them). After these works I would have rare PRs again unless there are new legacy (that should have been replaced) codes are found, the leap between v24 and v25, or when I found an unbearable bug that I can fix. Oh and don't worry, the checklist shows that the remaining cleanups won't touch the config part anymore, except the two that was announced to cease between v24 and v25. Salute to the maintainers, contributors and project supporters, everyone works with the field of anti-censorships. |
Why are you guys debating about non-existing things... I have to tell you that socks4(a) client in xray has never worked. See v2fly/v2ray-core#1968 and v2fly/v2ray-core#1971 |
Good job. Thank you. SOCKS 4/4a client just don't have a shadow in documents of XTLS. Nothing worry. No burden to remove. Yay. |
@APT-ZERO please stop talking s**t everyday if you want something you can be the developer for it |
没看到文档中有,直接清掉不用留着报错 我想了一下这个 pr 里的都可以直接清掉不用留着报错,包括单个 fallback 从未出现在 Xray 的文档中 |
单开,快的话这个 pr 今天就能合 |
前几天在 XTLS/Xray-docs-next#577 才清理掉的,属于遗留长尾,就是不知道会不会有不少还在用这个设置的。
这个可以。 |
直接删掉就好 |
不过我想了下还是明天再合然后发个版吧, |
就绪,随时可合 |
结果 router 的代码整理搭了便车 |
I've seen many users make the mistake of not setting the timeout value in Xray, which causes errors. Then, they mistakenly assume that 3x-ui has a bug.
移除:
变更
功能弃用提示(需在 release note 注明)
由于 Dokodemo 与 HTTP 入站的超时设置也在功能弃用中(其功能均迁移至 userLevel),但一直未在文档中移除,现加入弃用提示并在 v25 前清理代码功能,防止下游客户端向即将移除的配置项填写内容导致完全无法运行。
ProtoBreak:此 pr 需要更新所有的 pb 配置。