Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: socks4/4a client handshake #1971

Merged
merged 1 commit into from
Oct 8, 2022
Merged

fix: socks4/4a client handshake #1971

merged 1 commit into from
Oct 8, 2022

Conversation

dyhkwong
Copy link
Contributor

fix #1968

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Base: 38.88% // Head: 38.82% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (5166577) compared to base (2e0ea88).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1971      +/-   ##
==========================================
- Coverage   38.88%   38.82%   -0.06%     
==========================================
  Files         616      616              
  Lines       36336    36375      +39     
==========================================
- Hits        14128    14122       -6     
- Misses      20630    20673      +43     
- Partials     1578     1580       +2     
Impacted Files Coverage Δ
proxy/socks/client.go 0.72% <0.00%> (-0.04%) ⬇️
proxy/socks/protocol.go 14.70% <0.00%> (-1.53%) ⬇️
app/dns/dnscommon.go 86.36% <0.00%> (-2.28%) ⬇️
transport/internet/headers/http/http.go 83.54% <0.00%> (-1.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kslr kslr changed the title fix socks4/4a client handshake fix: socks4/4a client handshake Oct 8, 2022
@kslr kslr merged commit d467eb7 into v2fly:master Oct 8, 2022
@dyhkwong dyhkwong deleted the fix-socks4 branch October 8, 2022 23:50
maskedeken pushed a commit to maskedeken/v2ray-core that referenced this pull request Mar 10, 2023
Co-authored-by: ksco.he <ksco.he@ponyft.com>
Co-authored-by: 秋のかえで <autmaple@protonmail.com>

Chore: bump google.golang.org/grpc from 1.49.0 to 1.50.0 (v2fly#2046)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: socks4/4a client handshake (v2fly#1971)

Feat: add transport original name to listen unix (v2fly#2048)

Feat: add bind to device to Windows and Darwin (v2fly#1972)

fix: Replace "math/rand" with "crypto/rand" in padding generation(v2fly#2032)

Chore: github.com/lucas-clemente/quic-go from 0.29.0 to 0.29.1 (v2fly#2010)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat: Replace default Health Ping URL to HTTPS (v2fly#1991)

Chore: update dependencies (v2fly#1995)

Refactor: replace netaddr package with netipx (v2fly#1994)

Fix: remove v2ctl from debian/rules (v2fly#1954)

* Remove v2ctl from debian/rules

It seems to be left over from v2fly#488

* Chore: use Go v1.19 to build debian package

Co-authored-by: Loyalsoldier <10487845+Loyalsoldier@users.noreply.github.com>

Chore: bump google.golang.org/grpc from 1.48.0 to 1.49.0 (v2fly#1935)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Chore: bump github.com/google/go-cmp from 0.5.8 to 0.5.9 (v2fly#1959)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Chore: bump github.com/jhump/protoreflect from 1.12.0 to 1.13.0 (v2fly#1982)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat: Implement Match and MatchAny for all MatcherGroup, IndexMatcher

[common/strmatcher] Implement Match and MatchAny for all MatcherGroup and IndexMatcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socks4/4a client does not work
4 participants