Vck5000 IRON Support #1140

eddierichter-amd · 2024-03-19T21:11:56Z

Adding dynamic data movement support from IRON examples to VCK5000 AIE1

reference_designs/IRON-examples/matrix_add_one/aie2.py

reference_designs/IRON-examples/passthrough_hardware/aie2.py

reference_designs/ipu-xrt/vector_max/aie2.py

reference_designs/ipu-xrt/vector_min/aie2.py

reference_designs/ipu-xrt/vector_sum/aie2.py

reference_designs/lit.cfg.py

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

runtime_lib/test_lib/test_library.cpp|229|
runtime_lib/test_lib/test_library.h|23|
runtime_lib/test_lib/test_library.h|25|
runtime_lib/test_lib/test_library.h|129|

reference_designs/dynamic_dma_config_add_one/test.cpp

reference_designs/dynamic_dma_config_add_one_kernel/test.cpp

reference_designs/ipu-xrt/vector_sum/test.cpp

runtime_lib/test_lib/test_library.cpp

reference_designs/IRON-examples/add_one_objFifo_no_mem_tile/aie2.py

reference_designs/IRON-examples/matrix_add_one/aie2.py

reference_designs/IRON-examples/passthrough_hardware/aie2.py

reference_designs/IRON-examples/vector_add/aie2.py

reference_designs/IRON-examples/vector_max/aie2.py

reference_designs/IRON-examples/vector_min/aie2.py

reference_designs/IRON-examples/vector_mult/aie2.py

reference_designs/IRON-examples/vector_scalar/aie2.py

reference_designs/IRON-examples/vector_sum/aie2.py

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

reference_designs/IRON-examples/matrix_add_one/test_vck5000.cpp

reference_designs/IRON-examples/vector_max/test_vck5000.cpp

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

reference_designs/IRON-examples/vector_add/test.cpp

reference_designs/IRON-examples/vector_max/test_vck5000.cpp

reference_designs/IRON-examples/vector_scalar/test_vck5000.cpp

reference_designs/IRON-examples/vector_sum/test_vck5000.cpp

runtime_lib/test_lib/test_library.cpp

runtime_lib/test_lib/test_library.h

github-actions · 2024-03-20T02:47:30Z

Coverage Report

Created: 2024-03-22 19:51

Click here for information about interpreting this report.

Filename	Function Coverage	Line Coverage	Region Coverage	Branch Coverage
Totals	-	-	-	-

Generated by llvm-cov -- llvm version 14.0.0

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

include/aie/Targets/AIETargets.h

lib/Targets/AIETargetHSA.cpp

reference_designs/IRON-examples/matrix_add_one/test_vck5000.cpp

lib/Targets/AIETargetHSA.cpp

reference_designs/lit.cfg.py

test/lit.cfg.py

reference_designs/dynamic_dma_config_add_one/test.cpp

reference_designs/dynamic_dma_config_add_one_kernel/test.cpp

keryell · 2024-03-21T18:52:56Z

lib/Targets/AIETargetHSA.cpp

@@ -74,13 +74,18 @@ mlir::LogicalResult AIETranslateToHSA(ModuleOp module, raw_ostream &output) {
  }

  // Getting the sequence function op which contains the instructions
-  mlir::func::FuncOp funcOp;
+  mlir::func::FuncOp funcOp = NULL;


No NULL in C++ since 2011. Use nullptr instead.

keryell · 2024-03-21T19:47:23Z

reference_designs/IRON-examples/matrix_add_one/run_vck5000.lit

@@ -0,0 +1,10 @@
+// (c) Copyright 2023 Advanced Micro Devices, Inc.


Happy new years everywhere?

keryell · 2024-03-21T19:50:15Z

reference_designs/IRON-examples/lit.local.cfg

+config.unsupported = []
+
+if not config.has_libxaie:
+    config.unsupported = ['IRON-examples']


Perhaps it is a good opportunity to introduce some new variables here so instead of copy-pasting
%python aiecc.py %VitisSysrootFlag% --host-target=%aieHostTargetTriplet% %link_against_hsa% ./aie.mlir -I%host_runtime_lib%/test_lib/include %extraAieCcFlags% %S/test_vck5000.cpp -o test.elf -L%host_runtime_lib%/test_lib/lib -ltest_lib
all over the place we can just have
%aiecc %iron_test
or something like that?

Good idea! We do need to add some logic of course to differentiate between the IPU and VCK5000 build instructions, but can encode that in %iron_test. I don't know if I want to put it in this PR as it is already incorporating a bunch of changes but if you want to take that in a separate branch that would be great :)

No emergency.
At least we could start thinking about how many different classes of tests we have first.

reference_designs/lit.cfg.py

test/lit.cfg.py

* Adding comments to build-mlir-aie.sh on how to point to the ROCm runtime * Updating documentation to build on VCK5000 and adding script to allow users to clone the ROCm-air-platforms repository * Updating build-mlir-aie that builds against the ROCm runtime as a new script, and updating the documentation to refer to the new script * Updating documentation on new way to build aie-rt that works with both Phoenix and VCK5000

… use this functionality

…ect fifo

…ode cleanup

…t the correct func op when there are multiple. Also adding more IRON tests to the vck5000 directory

…rked as done before exiting as well as destroying the signals at the end.

…o VCK5000 tests to have each test run one at a time

This comment was marked as outdated.

Sign in to view

github-actions bot reviewed Mar 19, 2024

View reviewed changes

github-actions bot reviewed Mar 20, 2024

View reviewed changes

eddierichter-amd force-pushed the vck5000-dynamic-dma-config branch from 9d80671 to 957b7d9 Compare March 20, 2024 17:19

github-actions bot reviewed Mar 20, 2024

View reviewed changes

github-actions bot reviewed Mar 21, 2024

View reviewed changes

lib/Targets/AIETargetHSA.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Mar 21, 2024

View reviewed changes

keryell reviewed Mar 21, 2024

View reviewed changes

eddierichter-amd force-pushed the vck5000-dynamic-dma-config branch 2 times, most recently from 3612a28 to 50fac6c Compare March 21, 2024 21:33

github-actions bot reviewed Mar 21, 2024

View reviewed changes

reference_designs/lit.cfg.py Outdated Show resolved Hide resolved

test/lit.cfg.py Outdated Show resolved Hide resolved

eddierichter-amd force-pushed the vck5000-dynamic-dma-config branch from 0e0ead2 to fd13b41 Compare March 22, 2024 19:45

eddierichter-amd and others added 10 commits March 22, 2024 13:47

Adding a air_nd_memcpy to mlir-aie and creating a reference design to…

15b6589

… use this functionality

Adding a dynamic data movement example that links with the kernel

c9e01bb

Adding another referende design which is add one with kernels and obj…

c397f7c

…ect fifo

Adding an HSA datamovement target to compile ipu dma instructions

b7d97a9

Adding a test in ipu-xrt that works across IPU and VCK5000 and some c…

0078a5d

…ode cleanup

Enable lit testing in vck5000-dynamic-dma-config branch (#1124)

d31bd08

Removing including header files in generated data movement file

2262a85

[vck5000-dynamic-dma-config] more test cleanups (#1127)

1531e50

Changing air to mlir-aie

6899a0b

eddierichter-amd added 19 commits March 22, 2024 13:47

Moving vck5000 reference designs to seperate folder

62e8edc

Adding passthrough design for vck5000

2e3286d

Updating the HSA target to correctly get the channel ID as well as ge…

d550162

…t the correct func op when there are multiple. Also adding more IRON tests to the vck5000 directory

Cleanup and adding multi-dimensional memcpy example

cd07eb9

Updating documentation on VCK5000 and testing things on IPU

b395f1a

Cleaning up VCK5000 examples

c3abe39

Adding 3 more examples to VCK5000

62fadfb

Updating HSA target to make sure all packet completion signals are ma…

0de0011

…rked as done before exiting as well as destroying the signals at the end.

Reorganizing vck5000 references and making them support IPU as well

a5d14c3

Adding IRON examples

d6c983e

Making all tests in IRON-examples platform agnostic

e648ca8

Fixing examples

924ecd2

Small fixup

fb24af6

small fixes

7e653bb

Small fixup

a54bc1e

clang-format

fc3fc08

Initial implementation of lit testing on VCK5000

8d29423

Small fixes to CMake lit testing configuration and adding file lock t…

97c8c69

…o VCK5000 tests to have each test run one at a time

Getting lit tests working on reference designs and aie1 unit tests

ea5c1a5

eddierichter-amd force-pushed the vck5000-dynamic-dma-config branch from fd13b41 to ea5c1a5 Compare March 22, 2024 19:47

eddierichter-amd marked this pull request as ready for review March 22, 2024 20:27

eddierichter-amd requested a review from fifield March 22, 2024 20:28

eddierichter-amd closed this Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vck5000 IRON Support #1140

Vck5000 IRON Support #1140

eddierichter-amd commented Mar 19, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot left a comment

keryell Mar 21, 2024

keryell Mar 21, 2024

keryell Mar 21, 2024

eddierichter-amd Mar 21, 2024

keryell Mar 22, 2024

		@@ -0,0 +1,10 @@
		// (c) Copyright 2023 Advanced Micro Devices, Inc.

Vck5000 IRON Support #1140

Vck5000 IRON Support #1140

Conversation

eddierichter-amd commented Mar 19, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 20, 2024 • edited Loading

Coverage Report

Created: 2024-03-22 19:51

Generated by llvm-cov -- llvm version 14.0.0

github-actions bot left a comment

Choose a reason for hiding this comment

keryell Mar 21, 2024

Choose a reason for hiding this comment

keryell Mar 21, 2024

Choose a reason for hiding this comment

keryell Mar 21, 2024

Choose a reason for hiding this comment

eddierichter-amd Mar 21, 2024

Choose a reason for hiding this comment

keryell Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 20, 2024 •

edited

Loading