This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Do not update when a special buffer is selected #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And “special” here, means anything else that a normal buffer (a file). Additionaly make sure we reset the alternate window as well so we can keep using that as expected. For details why this fix is needed, please see this issue ctrlpvim/ctrlp.vim#235 and the comments (mainly the last 5 or so) of this PR ctrlpvim/ctrlp.vim#303
|
@Xuyuanp could you please have a look at this one and merge it if you are OK with it? It fixes a long standing issue with the If you have any thoughts or comments please let me know so we can work towards a solution that can be merged. Thx! |
|
Looks good to me. Thank you. |
|
Nice work. :) |
|
@mattn thx... So the issue reported with |
3 tasks
|
@svanharmelen Hi, what's the software you use to record screen? |
|
That's Giphy Capture: http://giphy.com/apps#giphycapture It's only available for OSX/macOS... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And “special” here, means anything else that a normal buffer (a file).
Additionally make sure we reset the alternate window as well so we can keep using that as expected.
For details why this fix is needed, please see this issue ctrlpvim/ctrlp.vim#235 and the comments (mainly the last 5 or so) of this PR ctrlpvim/ctrlp.vim#303