Do not update when a special buffer is selected #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see Xuyuanp/nerdtree-git-plugin#63 including the comments and the references to an issue logged with the `CtrlP` plugin. This PR implements the same fix as users have reported the same issue when using this plughin as well.
|
Good stuff and thanks for this! I usually like to test things out even for the most benign changes but this same fix has already been applied elsewhere as you mentioned. 😄 For now I am going to merge and do version update later |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word “special” in the title, in this case means anything else that a normal buffer (a file). Additionally make sure we reset the alternate window as well so we can keep using that as expected.
For details why this fix is needed, please see this issue ctrlpvim/ctrlp.vim#235 and the comments (mainly the last 5 or so) of this PR ctrlpvim/ctrlp.vim#303
Also please see Xuyuanp/nerdtree-git-plugin#63 as the related code was copied from there and they just merged the same fix as well. So this PR implements that same fix as users have reported the same issue when using this plugin as well.