Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding page #43

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Holding page #43

merged 1 commit into from
Dec 5, 2024

Conversation

danrparker
Copy link
Contributor

Description

This pull request introduces several changes to the app.vue, assets/css/main.css, and various components to enhance the styling and functionality of the countdown and holding pages. The most important changes include updating the layout and styles, adding a countdown component, and integrating social media links.

Layout and Styling Updates:

  • app.vue: Updated the main container to use Tailwind CSS classes for better layout and styling.
  • assets/css/main.css: Added custom styles for the countdown tiles and text, and applied a new font and color scheme to the body.

Countdown Component:

  • components/Countdown.vue: Added a new countdown component that displays the remaining time in days, hours, minutes, and seconds until a specified date.

Holding Page Enhancements:

Configuration Changes:

  • nuxt.config.ts: Included the new CSS file and added external stylesheets for fonts and icons in the head configuration.

Checklist

  • I accept the contributor license agreement for this repository.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used (if not main).
  • A GitHub issue or linear task is linked to this pull request.

@danrparker danrparker requested a review from a team as a code owner December 5, 2024 16:23
Copy link

linear bot commented Dec 5, 2024

ROS-34 Holding page

Holding page with a countdown to the weekend and updated branding

@nathanbillis nathanbillis changed the base branch from main to develop December 5, 2024 16:24
@nathanbillis nathanbillis merged commit b3d84f5 into develop Dec 5, 2024
4 of 5 checks passed
nathanbillis added a commit that referenced this pull request Dec 5, 2024
Co-authored-by: danrparker <95368712+danrparker@users.noreply.github.com>
@nathanbillis nathanbillis deleted the dparker/ros-34 branch December 5, 2024 16:27
nathanbillis added a commit that referenced this pull request Dec 5, 2024
* Holding page (#43)

* Dparker/ros 34 (#45)

* Holding page

* Style Fix

---------

Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Co-authored-by: Nathan Billis <nathanbillis@users.noreply.github.com>

---------

Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Co-authored-by: danrparker <95368712+danrparker@users.noreply.github.com>
nathanbillis added a commit that referenced this pull request Dec 9, 2024
* Holding page (#43)

* Dparker/ros 34 (#45)

* Holding page

* Style Fix

---------

Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Co-authored-by: Nathan Billis <nathanbillis@users.noreply.github.com>

* Holding page tweaks (#47)

* Holding page tweaks

* Fixed font on Safari, added correct favicon

---------

Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Co-authored-by: danrparker <95368712+danrparker@users.noreply.github.com>
nathanbillis added a commit that referenced this pull request Dec 10, 2024
* Holding page (#43)

* Dparker/ros 34 (#45)

* Holding page

* Style Fix

---------

Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Co-authored-by: Nathan Billis <nathanbillis@users.noreply.github.com>

* Holding page tweaks (#47)

* Holding page tweaks

* Fixed font on Safari, added correct favicon

* fix eslint and add meta tags (#49)

---------

Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Co-authored-by: danrparker <95368712+danrparker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants