Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev into main #50

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Merge dev into main #50

merged 6 commits into from
Dec 10, 2024

Conversation

nathanbillis
Copy link
Contributor

This pull request includes several changes aimed at improving code quality, consistency, and functionality. The changes span multiple files and address various aspects such as ESLint configuration, HTML structure, CSS styling, and Sentry configuration.

ESLint Configuration and Prettier Integration:

  • .eslintrc.json: Removed the existing Prettier configuration.
  • .vscode/settings.json: Enabled the use of flat ESLint configuration.
  • eslint.config.js: Integrated eslint-config-prettier and eslint-plugin-prettier/recommended for better code formatting consistency.

HTML and CSS Updates:

  • app.vue: Updated the HTML structure to include meta tags and adjusted the layout for better presentation.
  • assets/css/main.css: Modified the text styling and adjusted the countdown tile styles for a more polished look.
  • components/HoldingPage.vue: Enhanced the layout and styling of the holding page, including image and text adjustments.
  • components/Socials.vue: Added screen reader-only text for better accessibility of social media links.

Sentry Configuration:

These changes collectively improve the project's code quality, maintainability, and user experience.

danrparker and others added 5 commits December 5, 2024 16:26
* Holding page

* Style Fix

---------

Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Co-authored-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
* Holding page tweaks

* Fixed font on Safari, added correct favicon
@nathanbillis nathanbillis requested a review from a team as a code owner December 10, 2024 10:15
Signed-off-by: Nathan Billis <nathanbillis@users.noreply.github.com>
Copy link

Deploying roses-live with  Cloudflare Pages  Cloudflare Pages

Latest commit: a381a09
Status:⚡️  Build in progress...

View logs

@nathanbillis nathanbillis merged commit bd1b450 into main Dec 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants