Skip to content

Commit

Permalink
remove esbuild config (redwoodjs#3541)
Browse files Browse the repository at this point in the history
Co-authored-by: David Price <thedavid@thedavidprice.com>
  • Loading branch information
7shantanu7 and thedavidprice authored Oct 16, 2021
1 parent 0446a59 commit d788d79
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 31 deletions.
6 changes: 0 additions & 6 deletions packages/codemods/src/lib/getRWPaths.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ interface Config {
stories: boolean
nestScaffoldByModel: boolean
}
experimental: {
esbuild: boolean
}
}

// Note that web's includeEnvironmentVariables is handled in `webpack.common.js`
Expand Down Expand Up @@ -82,9 +79,6 @@ const DEFAULT_CONFIG: Config = {
stories: true,
nestScaffoldByModel: true,
},
experimental: {
esbuild: false,
},
}

/**
Expand Down
14 changes: 0 additions & 14 deletions packages/core/config/webpack.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,6 @@ module.exports = (webpackEnv) => {
const shouldIncludeFastRefresh =
redwoodConfig.web.experimentalFastRefresh && !isEnvProduction

const shouldUseEsbuild = process.env.ESBUILD === '1'

return {
mode: isEnvProduction ? 'production' : 'development',
devtool: isEnvProduction ? 'source-map' : 'cheap-module-source-map',
Expand Down Expand Up @@ -274,12 +272,6 @@ module.exports = (webpackEnv) => {
].filter(Boolean),
},
},
shouldUseEsbuild && {
loader: 'esbuild-loader',
options: {
loader: 'jsx',
},
},
].filter(Boolean),
},
// (2)
Expand All @@ -297,12 +289,6 @@ module.exports = (webpackEnv) => {
].filter(Boolean),
},
},
shouldUseEsbuild && {
loader: 'esbuild-loader',
options: {
loader: 'tsx',
},
},
].filter(Boolean),
},
// .module.css (3), .css (4), .module.scss (5), .scss (6)
Expand Down
3 changes: 0 additions & 3 deletions packages/internal/src/__tests__/config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ describe('getConfig', () => {
"browser": Object {
"open": false,
},
"experimental": Object {
"esbuild": false,
},
"generate": Object {
"nestScaffoldByModel": true,
"stories": true,
Expand Down
6 changes: 0 additions & 6 deletions packages/internal/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ export interface Config {
stories: boolean
nestScaffoldByModel: boolean
}
experimental: {
esbuild: boolean
}
}

// Note that web's includeEnvironmentVariables is handled in `webpack.common.js`
Expand Down Expand Up @@ -82,9 +79,6 @@ const DEFAULT_CONFIG: Config = {
stories: true,
nestScaffoldByModel: true,
},
experimental: {
esbuild: false,
},
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,4 @@ export default `
port = 8911
[browser]
open = true
[experimental]
esbuild = false
`

0 comments on commit d788d79

Please sign in to comment.