Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUPP-572 Apply core class to get margins right #254

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented Jun 6, 2022

Context

  • We want to fix the margins here:
    Screenshot 2022-06-06 at 12-51-06 Edit Post “Hello world!” ‹ Basic — WordPress

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where a section in the Classic Editor's submitbox would be displayed with incorrect margins.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • create a R&R copy and edit it
  • check that the margins are now correct

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes DUPP-572

@maartenleenders
Copy link
Contributor

🎉

@maartenleenders maartenleenders merged commit af7bb98 into trunk Jun 10, 2022
@maartenleenders maartenleenders deleted the DUPP-572-fix-margins branch June 10, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants