Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
gettext
, to avoid performance issues.Summary
This PR can be summarized in the following changelog entry:
gettext
filter.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
We should check that the labels are still rewritten, and that the number to the affecting methods is much lower.
Regression test
Check that we hook only in the edit screen
Yoast\W\D\U\Classic_Editor->change_republish_strings_classic_editor()
andYoast\W\D\U\Classic_Editor->change_schedule_strings_classic_editor()
are hooked only on the edit post/page screensCheck the performance improvement
this is not easy to check because it's visible in environments with plenty of content, but a possible way could be:
Yoast\W\D\U\Classic_Editor->change_republish_strings_classic_editor()
andYoast\W\D\U\Classic_Editor->change_schedule_strings_classic_editor()
get_post()
is done in that case.Another idea:
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Documentation
Quality assurance
Fixes #185 DUPP-52