Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text domain to solve Jed localization error #11121

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Conversation

IreneStr
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • N/A

Relevant technical choices:

N/A

Test instructions

This PR can be tested by following these steps:

  • Use Gutenberg master.
  • Checkout hotfix/8.3.1
  • Open a post in the classic editor. See the error from the issue.
  • Checkout this branch.
  • Open a post in the classic editor. Open your console. See that the error is gone.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #11113

@afercia
Copy link
Contributor

afercia commented Sep 28, 2018

Note: this was also fixed in the pending ESLint PR #11099

@afercia
Copy link
Contributor

afercia commented Sep 28, 2018

Needs decision as #11099 is already in needs acceptance and already fixes this missing textdomain.

@IreneStr
Copy link
Contributor Author

@afercia Since the eslint PR is based on trunk and we need this for the hotfix, please merge this one (and remove the fix from the eslint PR).

@afercia
Copy link
Contributor

afercia commented Sep 28, 2018

OK thanks

(and remove the fix from the eslint PR).

ok, will do before merge to solve the merge conflict

@afercia
Copy link
Contributor

afercia commented Sep 28, 2018

CR and acceptance 👍

@afercia afercia merged commit d03f78c into hotfix/8.3.1 Sep 28, 2018
@afercia afercia added this to the 8.3.1 milestone Sep 28, 2018
@afercia afercia deleted the add-text-domain branch September 28, 2018 15:19
@IreneStr IreneStr modified the milestones: 8.3.1, 8.4 Oct 1, 2018
@abotteram abotteram mentioned this pull request Oct 10, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants