PHP 8.1 | Composer: update OAuth2-Client + underlying dependencies #17891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `league/oauth2-client` package has released a new version, which includes a PHP 8.1 fix we need. This commit just updates that package, without updating the underlying dependencies. Based on the changelog, this should be a safe update. Ref: https://github.com/thephpleague/oauth2-client/releases
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implementation of the `JSONSerializable` interface. See thephpleague/oauth2-client#919 This change removes the prefix from the use statement. PHP Scoper was updated to 0.15.0 during investigation of this issue and it still does not work as desired on the newer version. Bumping the version in this commit seemed out of scope. PHP 8.1 compatibility for PHP Scoper is being tracked in the following ticket: humbug/php-scoper#539
This updates the underlying dependencies of the `league/oauth2-client` package to more recent versions which still support PHP 5.6. This has been done as a controlled update, locking at specific versions. Refs: * https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md * https://github.com/guzzle/promises/blob/master/CHANGELOG.md * https://github.com/guzzle/psr7/blob/2.1.0/CHANGELOG.md * No changelog available for getallheaders, but not concerned about it as that package does not get prefixed anyway.
jrfnl
added
yoast cs/qa
changelog: other
composer.lockDev Package changes
Settings · Docs · Powered by Private Packagist |
herregroen
approved these changes
Dec 23, 2021
increddibelly
added
changelog: non-user-facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Composer: update OAuth2-Client
The
league/oauth2-clientpackage has released a new version, which includes a PHP 8.1 fix we need.This commit just updates that package, without updating the underlying dependencies.
Based on the changelog, this should be a safe update.
Ref: https://github.com/thephpleague/oauth2-client/releases
PHP 8.0/8.1 | Update OAuth PHP Scoper config
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implementation of the
JSONSerializableinterface.See thephpleague/oauth2-client#919
This change removes the prefix from the use statement.
PHP Scoper was updated to 0.15.0 during investigation of this issue and it still does not work as desired on the newer version. Bumping the version in this commit seemed out of scope.
PHP 8.1 compatibility for PHP Scoper is being tracked in the following ticket: humbug/php-scoper#539
Composer: controlled update of underlying dependencies
This updates the underlying dependencies of the
league/oauth2-clientpackage to more recent versions which still support PHP 5.6.This has been done as a controlled update, locking at specific versions.
Refs:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing: