Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 "attribute" use statement incorrectly prefixed or breaks prefixing entirely #539

Closed
moorscode opened this issue Oct 28, 2021 · 2 comments
Closed

PHP 8.0 "attribute" use statement incorrectly prefixed or breaks prefixing entirely #539

moorscode opened this issue Oct 28, 2021 · 2 comments
Labels
bug

Comments

@moorscode
Copy link
Contributor

moorscode commented Oct 28, 2021 •
edited
Loading

Bug report

Question Answer
PHP-Scoper version 0.15.0
PHP version all
Platform with version all

Prefixing of PHP 8.0+ attributes is not behaving consistently.

When using a single line attribute, which is imported using a use statement, the class in the use statement is being prefixed.

However, when using the fully qualified classname in the inline attribute call or using a multiline attribute notation the build files are created with expected prefixes (the incorrect prefix is not being added).

Correction on the assumption that multiline attributes were giving the desired results.
Whenever an attribute is defined over multiple lines, the "source" file is being placed in the build directory without any errors or warnings, but also without any prefixes.

I've added a "neutral" use SomethingElse; to the source files to validate that prefixing happens, though this statement is not being prefixed in the multiline-*.php files in the build results.

Steps to reproduce:

  1. Clone the main branch of the php-scoper-attributes-prefixed-poc repository
  2. Run composer install
  3. Run php ./vendor/humbug/php-scoper/bin/php-scoper add-prefix
  4. Inspect the files in the build directory and see use TestPrefix\ReturnTypeWillChange; instead of the use ReturnTypeWillChange; statement in the inline-with-use.php file
moorscode added a commit to Yoast/wordpress-seo that referenced this issue Oct 28, 2021
@moorscode
PHP 8.0 | Update OAuth PHP Scoper config
f6b106b 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Oct 28, 2021
@moorscode @jrfnl
PHP 8.0 | Update OAuth PHP Scoper config
3742972 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
@moorscode moorscode changed the title PHP 8.0 Parameter use statement incorrectly prefixed PHP 8.0 "parameter" use statement incorrectly prefixed or breaks prefixing entirely Oct 28, 2021
@moorscode moorscode changed the title PHP 8.0 "parameter" use statement incorrectly prefixed or breaks prefixing entirely PHP 8.0 "attribute" use statement incorrectly prefixed or breaks prefixing entirely Oct 28, 2021
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Nov 11, 2021
@moorscode @jrfnl
PHP 8.0 | Update OAuth PHP Scoper config
1a489a9 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Nov 30, 2021
@moorscode @jrfnl
PHP 8.0 | Update OAuth PHP Scoper config
6e43f90 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Nov 30, 2021
@moorscode @jrfnl
PHP 8.0 | Update OAuth PHP Scoper config
9198818 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Dec 6, 2021
@moorscode @jrfnl
PHP 8.0 | Update OAuth PHP Scoper config
bd31853 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Dec 9, 2021
@moorscode @jrfnl
PHP 8.0 | Update OAuth PHP Scoper config
af5d4b3 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Dec 16, 2021
@moorscode @jrfnl
WAIT tagged release | PHP 8.0 | Update OAuth PHP Scoper config
d9fea31 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Dec 16, 2021
@moorscode @jrfnl
WAIT tagged release | PHP 8.0 | Update OAuth PHP Scoper config
6743d35 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Dec 20, 2021
@moorscode @jrfnl
WAIT tagged release | PHP 8.0 | Update OAuth PHP Scoper config
6652fa8 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implenetation of the JSONSerializableInterface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and was not worked as desired on the newer version. Bumping the version in this commit seemed out of scope.

This is addressed in the following ticket: humbug/php-scoper#539
jrfnl pushed a commit to Yoast/wordpress-seo that referenced this issue Dec 23, 2021
@moorscode @jrfnl
PHP 8.0/8.1 | Update OAuth PHP Scoper config
61f6edb 
PHP Scoper is prefixing the attribute use statement that will need to be pulled into the TheLeague OAuth Client implementation of the `JSONSerializable` interface.
See thephpleague/oauth2-client#919

This change removes the prefix from the use statement.

PHP Scoper was updated to 0.15.0 during investigation of this issue and it still does not work as desired on the newer version. Bumping the version in this commit seemed out of scope.

PHP 8.1 compatibility for PHP Scoper is being tracked in the following ticket: humbug/php-scoper#539
@jrfnl jrfnl mentioned this issue Dec 23, 2021
Merged
1 task
@jrfnl jrfnl mentioned this issue Jan 7, 2022
Closed
@gordalina gordalina mentioned this issue Jan 9, 2022
Closed
@dereckson dereckson mentioned this issue Jan 22, 2022
Closed
@defunctl defunctl mentioned this issue Feb 2, 2022
Closed
@theofidry theofidry added the bug label Feb 11, 2022
@theofidry
Copy link
Member

Will be fixed in the next release. Not entirely sure if it's capture completely by #738, but I tried scoping the reproducer repository with the latest state of main and it works.

@jrfnl
Copy link

jrfnl commented Nov 12, 2022

Happy to hear that. Thank you @theofidry !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrfnl @moorscode @theofidry