Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradient accumulation and learning rate aggregation #1

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix gradient accumulation and learning rate aggregation #1

merged 3 commits into from
Dec 18, 2024
+38 −29

Conversation

jeffpicard
Copy link
Collaborator

This is PR'ed to the upstream here, more details there.

But requesting to merge to Ziprecruiter/main as well (i.e. to land sooner).

MattGPT-ai
MattGPT-ai approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@MattGPT-ai MattGPT-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Want to merge this and change our build to use this PR so I can test this in action

flair/trainers/plugins/functional/checkpoints.py Show resolved Hide resolved
flair/trainers/trainer.py Show resolved Hide resolved
@jeffpicard jeffpicard merged commit 70b7bd0 into main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGPT-ai MattGPT-ai MattGPT-ai approved these changes

Assignees

@MattGPT-ai MattGPT-ai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffpicard @MattGPT-ai