Multigpu: Fix gradient accumulation and learning rate aggregation #3583
+38
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR fixes 3 bugs with multi-gpu training:
multi_gpu=True
, but ideally it should stay the same to let knobs be turned independently, and this PR does that.multi_gpu=True
andsave_model_each_k_epochs>0
training will freeze. Currently the plugin runsbarrier
which waits for other processes to catchup, but the plugin is only run on the main process, so they never will.