-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audio normalizing for mute clips #1401
Conversation
Does this change warrant a change to the docstring for Also, does this change warrant a comment explaining what is happening (check box 4), or is it simple enough to be left as is? |
Adds clarifying comments to the code and sentence the docstring for the audio_normalize effect.
Hey, sorry for the late response. This looks great, and I like your docstring change and comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. I have some suggestions that could improve your pull request. I'm not sure if @tburrows13 agrees with them, could confirm it?
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me is perfect. Feel free to merge it @tburrows13
Thank you for this fix @jcbrockschmidt!
Resolves issue #1388. Code that only runs when the fix is applied can be found in
tests/test_fx.py
withintest_normalize_muted
, and here for convenience:tests/
black -t py36