Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #1355

Open
tburrows13 opened this issue Oct 15, 2020 · 3 comments
Open

Add more tests #1355

tburrows13 opened this issue Oct 15, 2020 · 3 comments
Labels
good-first-issue Especially suitable for people new to moviepy and/or programming; beginner-friendly. tests Related to individual tests in the test suite or running the test suite.

Comments

@tburrows13
Copy link
Collaborator

The test coverage is currently at 67%. It would be good to be able to automatically test more things in the test suite. You can see which files are covered at https://coveralls.io/github/Zulko/moviepy (or PyCharm has a test coverage plugin that can be enabled).

In particular:

  • some effects in moviepy/video/fx are not tested at all in their respective test function in test_fx.py.
  • video/compositing/transitions.py
  • audio/fx/audio_fadein and audio_fadeout

For the video tests it is better to use BitmapClip because it allows you to test pixel-perfect effects. But generally just testing that an action can be performed without crashing is better than nothing.

@tburrows13 tburrows13 added tests Related to individual tests in the test suite or running the test suite. good-first-issue Especially suitable for people new to moviepy and/or programming; beginner-friendly. labels Oct 15, 2020
@tburrows13 tburrows13 changed the title More tests Add more tests Oct 15, 2020
@mondeja
Copy link
Collaborator

mondeja commented Jan 21, 2021

FX tests checklist

💯 means 100% coverage

Video / audio

Audio


Video tools tests checklist

💯 means 100% coverage

@tburrows13
Copy link
Collaborator Author

It would be quite hard to write BitmapClip tests for all of the effects, I think. Although you did manage with blackwhite in #1430 I wouldn't say it is worth it for some of the more 'color-gradienty' ones (such as headblur and painting).

@mondeja
Copy link
Collaborator

mondeja commented Jan 23, 2021

It would be quite hard to write BitmapClip tests for all of the effects...

I have found it much easier to use ColorClip in tests for mask_or and mask_and testing ImageClip and np.ndarray types as arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Especially suitable for people new to moviepy and/or programming; beginner-friendly. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

No branches or pull requests

2 participants