Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all 'rotate' FX arguments combinations #1484

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Test all 'rotate' FX arguments combinations #1484

merged 2 commits into from
Jan 23, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 23, 2021

Contributes to #1355

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja changed the title Tests all 'rotate' FX arguments combinations Test all 'rotate' FX arguments combinations Jan 23, 2021
@mondeja mondeja added tests Related to individual tests in the test suite or running the test suite. video Related to VideoClip and related classes, or handling of video in general. fx Related to advanced effects applied via clip.fx(), or effects in general. labels Jan 23, 2021
@mondeja mondeja mentioned this pull request Jan 23, 2021
Open
@coveralls
Copy link

coveralls commented Jan 23, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 66.978% when pulling fae2948 on mondeja:rotate-tests into 736abcc on Zulko:master.

@mondeja mondeja marked this pull request as draft January 23, 2021 11:28
@mondeja mondeja marked this pull request as ready for review January 23, 2021 11:39
@mondeja mondeja merged commit b519687 into Zulko:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fx Related to advanced effects applied via clip.fx(), or effects in general. tests Related to individual tests in the test suite or running the test suite. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls