Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for 'FramesMatches' #1588

Merged
merged 1 commit into from
May 25, 2021
Merged

Add tests for 'FramesMatches' #1588

merged 1 commit into from
May 25, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented May 25, 2021 •
edited
Loading

  • Allow to pass logger argument to FramesMatches.from_clip.
  • Add __eq__ method to FramesMatch object.
  • Add tests and document properly FramesMatches methods filter, load, save and from_clip.

Contributes to #1355

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja added refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. tests Related to individual tests in the test suite or running the test suite. video Related to VideoClip and related classes, or handling of video in general. labels May 25, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 74.472% when pulling 052afde on mondeja:frames-matches-tests into e6764f5 on Zulko:master.

@mondeja mondeja merged commit d213793 into Zulko:master May 25, 2021
@mondeja mondeja deleted the frames-matches-tests branch May 25, 2021 12:14
@mondeja mondeja mentioned this pull request May 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. tests Related to individual tests in the test suite or running the test suite. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls