Increased all XXE severities in Java Rules to High #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks can lead to high or critical damage according to their contexts. Since the goal of SAST is to Reduce security Risk by decreasing Impact and Likelihood, we should consider the worst-case scenario when dealing with this kind of Injection. Because of that, its wise to consider XXE findings as High Severity, even so since our tool isn't able to understand the context of this kind of finding Signed-off-by: gustavomarinhozup <gustavo.marinho@zup.com.br>
gustavomarinhozup
requested review from
wiliansilvazup,
matheusalcantarazup,
lucasbrunozup,
nathanmartinszup and
oliveirafelipezup
as code owners
Signed-off-by: gustavomarinhozup <gustavo.marinho@zup.com.br>
wiliansilvazup
approved these changes
Apr 14, 2022
nathanmartinszup
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Increased the severity of XXE rules in Java to High
XXE attacks can lead to high or critical damage according to their contexts. Since the goal of SAST is to Reduce security Risk by decreasing Impact and Likelihood, we should consider the worst-case scenario when dealing with this kind of Injection. Because of that, its wise to consider XXE findings as High Severity without given context (which SAST is unable to discover)
Signed-off-by: gustavomarinhozup gustavo.marinho@zup.com.br