Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased all XXE severities in Java Rules to High #1056

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Increased all XXE severities in Java Rules to High #1056

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3060bc
Increased all XXE severities in Java Rules to High, because XXE attac…
gustavomarinhozup Apr 12, 2022
ffec1d6
Reverted deletion of commented deprecated code
gustavomarinhozup Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 7 additions & 25 deletions internal/services/engines/java/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func NewXMLParsingVulnerableToXXE() *text.Rule {
ID: "HS-JAVA-1",
Name: "XML parsing vulnerable to XXE",
Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
Severity: severities.Medium.ToString(),
Severity: severities.High.ToString(),
Confidence: confidence.Low.ToString(),
},
Type: text.AndMatch,
Expand All @@ -49,7 +49,7 @@ func NewXMLParsingVulnerableToXXEWithXMLInputFactory() *text.Rule {
ID: "HS-JAVA-2",
Name: "XML parsing vulnerable to XXE With XMLInputFactory",
Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
Severity: severities.Medium.ToString(),
Severity: severities.High.ToString(),
Confidence: confidence.Low.ToString(),
},
Type: text.AndMatch,
Expand All @@ -66,7 +66,7 @@ func NewXMLParsingVulnerableToXXEWithDocumentBuilder() *text.Rule {
ID: "HS-JAVA-3",
Name: "XML parsing vulnerable to XXE With DocumentBuilder",
Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
Severity: severities.Medium.ToString(),
Severity: severities.High.ToString(),
Confidence: confidence.Low.ToString(),
},
Type: text.AndMatch,
Expand All @@ -84,7 +84,7 @@ func NewXMLParsingVulnerableToXXEWithSAXParserFactory() *text.Rule {
ID: "HS-JAVA-4",
Name: "XML parsing vulnerable to XXE With SAXParserFactory",
Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
Severity: severities.Medium.ToString(),
Severity: severities.High.ToString(),
Confidence: confidence.Low.ToString(),
},
Type: text.AndMatch,
Expand All @@ -102,7 +102,7 @@ func NewXMLParsingVulnerableToXXEWithTransformerFactory() *text.Rule {
ID: "HS-JAVA-5",
Name: "XML parsing vulnerable to XXE With TransformerFactory",
Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
Severity: severities.Medium.ToString(),
Severity: severities.High.ToString(),
Confidence: confidence.Low.ToString(),
},
Type: text.AndMatch,
Expand All @@ -114,31 +114,13 @@ func NewXMLParsingVulnerableToXXEWithTransformerFactory() *text.Rule {
}
}

// Deprecated: Repeated vulnerability, same as HS-JAVA-5
//
//func NewXMLParsingVulnerableToXXEWithSchemaFactory() *text.Rule {
// return &text.Rule{
// Metadata: engine.Metadata{
// ID: "HS-JAVA-6",
// Name: "XML parsing vulnerable to XXE With TransformerFactory",
// Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
// Severity: severities.Medium.ToString(),
// Confidence: confidence.Low.ToString(),
// },
// Type: text.AndMatch,
// Expressions: []*regexp.Regexp{
// regexp.MustCompile(`SchemaFactory\.newInstance\(`),
// },
// }
//}

gustavomarinhozup marked this conversation as resolved.
Show resolved Hide resolved
func NewXMLParsingVulnerableToXXEWithDom4j() *text.Rule {
return &text.Rule{
Metadata: engine.Metadata{
ID: "HS-JAVA-7",
Name: "XML parsing vulnerable to XXE With Dom4j",
Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
Severity: severities.Medium.ToString(),
Severity: severities.High.ToString(),
Confidence: confidence.Low.ToString(),
},
Type: text.AndMatch,
Expand All @@ -155,7 +137,7 @@ func NewXMLParsingVulnerableToXXEWithJdom2() *text.Rule {
ID: "HS-JAVA-8",
Name: "XML parsing vulnerable to XXE With Jdom2",
Description: "XML External Entity (XXE) attacks can occur when an XML parser supports XML entities while processing XML received from an untrusted source. For more information checkout the CWE-611 (https://cwe.mitre.org/data/definitions/611.html) advisory.",
Severity: severities.Medium.ToString(),
Severity: severities.High.ToString(),
Confidence: confidence.Low.ToString(),
},
Type: text.AndMatch,
Expand Down