Add the concept of unreleased api_versions #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sailorlqh
approved these changes
Feb 14, 2024
capri-xiyue
approved these changes
Feb 14, 2024
capri-xiyue
pushed a commit
that referenced
this pull request
Feb 14, 2024
This is a simple hack for a very complex reason. In #428, there's a problem where abc CLI version 0.5.0 *thinks* that it supports api_version v1beta4, but it really doesn't. It just supports the in-progress subset of v1beta4 that was implemented at the time that 0.5.0 was released. This causes a problem because when abc v0.5.0 sees a test.yaml that has api_version v1beta4, it *should* say "I don't understand this version, please upgrade your abc CLI" but what it will actually say is a weird test failure involving the `.gitkeep` file. By bumping the soon-to-be-released api_version to v1beta5, that will be beyond what abc v0.5.0 thinks it can support, so it will correctly ask the user to upgrade. The underlying root cause (abc CLI thinks it supports api_versions that it really doesn't) is fixed in #430 , but obviously we can't fix v0.5.0 which is already out in the wild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it can be hard to release a new binary version because any unfinished features and api_versions will be exposed in that release. For example, we can't release a new binary version if api_version
v1beta4is unfinished, because the new binary will putapi_version: v1beta4in all the yaml files that it creates.Instead, we want the ability to release a new binary version at any time, with unfinished features hidden behind an api_version that is still hidden from the public.
To do this, we mark each release struct with a boolean indicating whether it is released or not. api_versions that are under construction will not be used by official release binaries. When a release build of abc creates a yaml file, the header will use api_version=$last_officially_released_api_version, not the api_version that's under construction at the time of release.