Create api_version v1beta5, same as v1beta4 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # templates/model/decode/decode.go
capri-xiyue
approved these changes
Feb 14, 2024
|
Not sure whether we want to do patch release for v0.5.0, for example having a v0.5.1 instead of bumping api version to v1beta5? |
Discussed offline. For historical purposes: I think v0.6.0 is coming soon enough that there's not much benefit in creating a v0.5.1, and would incur some extra work in backporting a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple hack for a very complex reason.
In #428, there's a problem where abc CLI version 0.5.0 thinks that it supports api_version v1beta4, but it really doesn't. It just supports the in-progress subset of v1beta4 that was implemented at the time that 0.5.0 was released. This causes a problem because when abc v0.5.0 sees a test.yaml that has api_version v1beta4, it should say "I don't understand this version, please upgrade your abc CLI" but what it will actually say is a weird test failure involving the
.gitkeepfile.By bumping the soon-to-be-released api_version to v1beta5, that will be beyond what abc v0.5.0 thinks it can support, so it will correctly ask the user to upgrade.
The underlying root cause (abc CLI thinks it supports api_versions that it really doesn't) is fixed in #430 , but obviously we can't fix v0.5.0 which is already out in the wild.