Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: do not require optional system utilities #887

Merged
merged 1 commit into from
Nov 19, 2023
Merged

vm: do not require optional system utilities #887

merged 1 commit into from
Nov 19, 2023

Conversation

LaszloGombos
Copy link
Contributor

"htop", "vim", "inetutils-ping", "dnsutils" are optional dependencies - only required for developers working on colima.

I'd like to get some feedback on possibly moving these packages out of the main codebase into the configuration file. This would enable developers removing these packages without patching colima core source code.

Thanks !

@LaszloGombos LaszloGombos changed the title vm: do not require system utilities vm: do not require optional system utilities Nov 18, 2023
@abiosoft
Copy link
Owner

I do agree that they can be moved outside of the main codebase.

The integration tests are failing because nslookup is assumed to exist for docker local domain name validation.
You would need modify the tests to manually install dnsutils in the VM.

@abiosoft
Copy link
Owner

The goal is to eventually have a custom generated Ubuntu image with only the necessary packages bundled.

@LaszloGombos
Copy link
Contributor Author

LaszloGombos commented Nov 18, 2023

I do agree that they can be moved outside of the main codebase.

Should I completely remove them, move them to embedded/defaults/colima.yaml or perhaps to embedded/defaults/template.yaml ?

You would need modify the tests to manually install dnsutils in the VM.

Thanks for the hint. Done.

The goal is to eventually have a custom generated Ubuntu image with only the necessary packages bundled.

Yes, make sense. is the idea to build up an image with debootsratp or simply purge packages from the current cloud image ?

@abiosoft
Copy link
Owner

Should I completely remove them, move them to embedded/defaults/colima.yaml or perhaps to embedded/defaults/template.yaml?

I think they can be completely removed and example in the provision section of the config should suffice.

@abiosoft
Copy link
Owner

Yes, make sense. is the idea to build up an image with debootsratp or simply purge packages from the current cloud image ?

I do not know which one is easier. Actually we can create a separate issue to track that.

@abiosoft abiosoft merged commit 2ba668f into abiosoft:main Nov 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants