Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: do not require optional system utilities #887

Merged
merged 1 commit into from
Nov 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,12 @@ jobs:

- name: Delay
run: sleep 10

- name: Validate Docker
run: docker ps && docker info

- name: Validate DNS
run: colima ssh -- nslookup host.docker.internal
run: colima ssh -- sh -c "sudo apt-get update -y -qq && sudo apt-get install -qq dnsutils && nslookup host.docker.internal"

- name: Build Image
run: docker build integration
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
run: colima nerdctl ps && colima nerdctl info

- name: Validate DNS
run: colima ssh -- nslookup host.docker.internal
run: colima ssh -- sh -c "sudo apt-get update -y -qq && sudo apt-get install -qq dnsutils && nslookup host.docker.internal"

- name: Build Image
run: colima nerdctl -- build integration
Expand Down
2 changes: 1 addition & 1 deletion embedded/defaults/colima.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ cpuType: host
# EXAMPLE - script executed as root
# provision:
# - mode: system
# script: apk add htop vim
# script: apt-get install htop vim
#
# EXAMPLE - script executed as user
# provision:
Expand Down
2 changes: 0 additions & 2 deletions environment/vm/lima/deb/mantic.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ var manticPackages = []string{
"iptables",
// k8s
"socat",
// utilities
"htop", "vim", "inetutils-ping", "dnsutils",
}

var _ URISource = (*Mantic)(nil)
Expand Down
Loading