-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Split REST functionality into a tree-shakable module
This moves the following functionality from BaseRest into a new module named Rest: - methods that wrap REST endpoints (e.g. `stats`) - the `request` method - all functionality accessed via `BaseRest.channels` and `BaseRest.push` This renders the BaseRest class fairly useless by itself (the above functionality is pretty much everything it can do) but it allows us to now construct a BaseRealtime instance that doesn’t have REST functionality. Resolves #1374. Co-authored-by: Owen Pearson <owen.pearson@ably.com>
- Loading branch information
1 parent
40d70ce
commit c82ffa5
Showing
7 changed files
with
252 additions
and
171 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
export interface ModulesMap {} | ||
import { Rest } from './rest'; | ||
|
||
export const allCommonModules: ModulesMap = {}; | ||
export interface ModulesMap { | ||
Rest?: typeof Rest; | ||
} | ||
|
||
export const allCommonModules: ModulesMap = { Rest }; |
Oops, something went wrong.