Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tree-shakeable BaseClient and Rest modules #1374

Closed
owenpearson opened this issue Jul 5, 2023 · 1 comment
Closed

Create tree-shakeable BaseClient and Rest modules #1374

owenpearson opened this issue Jul 5, 2023 · 1 comment
Assignees
@owenpearson

Comments

@owenpearson
Copy link
Member

owenpearson commented Jul 5, 2023 •
edited
Loading

  • Create two classes, BaseClient and Rest which are available from a separate import path from the main ably-js module
  • BaseClient optionally takes Rest as a second constructor argument, and if so, allows the REST API to be accessed
  • Should include a typescript interface for the new import path
@sync-by-unito
Copy link

sync-by-unito bot commented Jul 5, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3717

@owenpearson owenpearson mentioned this issue Jul 5, 2023
Closed
This was referenced Jul 18, 2023
Closed
Closed
Closed
Closed
Closed
Closed
lawrence-forooghian added a commit that referenced this issue Aug 2, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
fdf154b 
TODO what was the approach?

TODO why has this not reduced any size?

TODO does it make sense to have a BaseRest without REST?

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 2, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
d74015b 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This renders the BaseRest class fairly useless by itself (the above
functionality is pretty much everything it can do) but it allows us to
now construct a BaseRealtime instance that doesn’t have REST
functionality.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 3, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
cde9961 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This renders the BaseRest class fairly useless by itself (the above
functionality is pretty much everything it can do) but it allows us to
now construct a BaseRealtime instance that doesn’t have REST
functionality.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 3, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
c82ffa5 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This renders the BaseRest class fairly useless by itself (the above
functionality is pretty much everything it can do) but it allows us to
now construct a BaseRealtime instance that doesn’t have REST
functionality.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 15, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
de6ec05 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 15, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
44f89fa 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 15, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
a420d0e 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 15, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
72c29a5 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 16, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
dd80361 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 16, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
c9a0cc1 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 16, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
a6961a0 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 17, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
04ae4b1 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 17, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
292a886 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 17, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
77059ea 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 17, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
20415c5 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 21, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
b7503aa 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Aug 22, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
709ffcb 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Sep 5, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
cc57cba 
This moves the following functionality from BaseRest into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Sep 14, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
d24570c 
This moves the following functionality from BaseClient into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
fd8d1f8 
This moves the following functionality from BaseClient into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Oct 26, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
7ea3d72 
This moves the following functionality from BaseClient into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Nov 1, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
32e3f8f 
This moves the following functionality from BaseClient into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
lawrence-forooghian added a commit that referenced this issue Nov 6, 2023
@lawrence-forooghian @owenpearson
Split REST functionality into a tree-shakable module
89c0761 
This moves the following functionality from BaseClient into a new module
named Rest:

- methods that wrap REST endpoints (e.g. `stats`)
- the `request` method
- all functionality accessed via `BaseRest.channels` and `BaseRest.push`

This allows us to now construct a BaseRealtime instance that doesn’t
have REST functionality.

Note that the BaseRest class always includes the Rest module. This comes
after discussions in which we decided that it would be quite useless
without it.

Resolves #1374.

Co-authored-by: Owen Pearson <owen.pearson@ably.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenpearson owenpearson

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@owenpearson